-
Notifications
You must be signed in to change notification settings - Fork 46
Added pull_request_template.md #118
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,35 @@ | ||
| # Description | ||
|
|
||
| Please include a summary of changes, motivation and context for this PR. | ||
|
|
||
| Fixes # (issue) | ||
|
|
||
| ## Type of change | ||
|
|
||
| Please tick all options which are relevant. | ||
|
|
||
| - [ ] Bug fix | ||
| - [ ] New feature | ||
| - [ ] Added/removed dependencies | ||
| - [ ] Requires documentation updates | ||
|
|
||
| # Testing | ||
|
|
||
| Please describe the test(s) that you added and ran to verify your changes. | ||
|
|
||
| ## Test(s) description | ||
|
|
||
| **Test Configuration**: | ||
|
|
||
| * OS: | ||
|
|
||
| # Checklist: | ||
|
|
||
| - [ ] I have added tests that prove my fix is effective and/or that my feature works | ||
| - [ ] New and existing unit tests pass locally with my changes | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
| - [ ] I have used understandable variable names | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
| - [ ] I have squashed my commits into a single commit ready for review | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
| - [ ] I have run `git-clang-format HEAD~` on my changes | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
| - [ ] I have made corresponding changes to the documentation | ||
| - [ ] I have performed a self-review of my own code | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
| - [ ] I have commented my code, particularly in hard-to-understand areas | ||
|
mcbarton marked this conversation as resolved.
Outdated
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.