Refactoring some utilities#153
Conversation
|
We should also be able to used the get_start_message function instead of the following Lines 109 to 114 in 4745f72 |
|
clang-tidy review says "All clean, LGTM! 👍" |
|
Looked straightforward but for some reason the test_xcpp_kernel.py test fails for some reason. Need to have a look into it |
|
@vgvassilev @mcbarton I think this might have something to do with the patches in CppInterOp (y'all could help by confirming) cause through backtrace we get |
|
Caught the bug here. Sadly I was looking at all places except the function I had changed (the stack trace didn't help and confused me even more). It's an error with how xeus deals with extract_filename function, so have to fix that upstream. |
|
Why the nightly builds succeed then? |
c89eac9 to
aaab509
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #153 +/- ##
==========================================
- Coverage 80.72% 80.54% -0.18%
==========================================
Files 19 19
Lines 970 956 -14
Branches 93 88 -5
==========================================
- Hits 783 770 -13
+ Misses 187 186 -1
|
|
clang-tidy review says "All clean, LGTM! 👍" |
1 similar comment
|
clang-tidy review says "All clean, LGTM! 👍" |
|
This should be fixed after the next xeus release as jupyter-xeus/xeus#409 has been merged now ! |
| } | ||
| return res; | ||
| } | ||
|
|
There was a problem hiding this comment.
I'd keep the tests as upstream testing was a bit lacking last time I saw.
There was a problem hiding this comment.
Ahhh no worries I made sure to add a test here (https://github.com/anutosh491/xeus/blob/13aea3049c99df566ae54061432b57b100747e91/test/test_unit_kernel.cpp#L56-L65)
0f275bf to
a16fc37
Compare
Few utilities that we use are already implemented and tested through xeus. So we can just get rid of them !