Fix extract_filename function#409
Merged
JohanMabille merged 4 commits intojupyter-xeus:mainfrom Dec 17, 2024
Merged
Conversation
anutosh491
force-pushed
the
extract_filename
branch
from
e850dcb to
7af0b73
Compare
Member
|
Actually this change is not backward incompatible, even if it's changing the behavior, it's breaking the ABI only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the extract_filename function is going to be editing argv, then it also needs to make a corresponding change to argc.
I thought this would work right out off the bat when I was using it for xeus-cpp but it ends up giving me errors (shown in this PR compiler-research/xeus-cpp#153)