Refactor container_rename_linux_test.go to use Tigron#4687
Merged
ChengyuZhu6 merged 1 commit intocontainerd:mainfrom Jan 17, 2026
Merged
Conversation
JoonsooWon
force-pushed
the
issues_4613_container_rename_linux_test.go
branch
from
7766afc to
bd340dd
Compare
46 tasks
ChengyuZhu6
reviewed
Jan 13, 2026
Member
ChengyuZhu6
left a comment
ChengyuZhu6
left a comment
There was a problem hiding this comment.
@JoonsooWon Could you please squash your commits into one? Thanks!
JoonsooWon
force-pushed
the
issues_4613_container_rename_linux_test.go
branch
from
11e4801 to
59f01b9
Compare
Contributor
Author
|
Thanks. |
JoonsooWon
force-pushed
the
issues_4613_container_rename_linux_test.go
branch
from
3f665de to
59f01b9
Compare
Contributor
Author
|
The PR was briefly broken due to an incorrect remote sync on my side. |
ChengyuZhu6
reviewed
Jan 15, 2026
JoonsooWon
force-pushed
the
issues_4613_container_rename_linux_test.go
branch
from
59f01b9 to
73c6de1
Compare
haytok
reviewed
Jan 15, 2026
|
|
||
| func TestRenameUpdateHosts(t *testing.T) { | ||
| t.Parallel() | ||
| testutil.DockerIncompatible(t) |
Member
There was a problem hiding this comment.
Sorry for the late review ...
Can we replace testutil.DockerIncompatible(t) with require.Not(nerdtest.Docker)?
Thanks!
Contributor
Author
There was a problem hiding this comment.
Thanks for the review.
It's good idea.
I fixed it!
Signed-off-by: Joonsoo Won <wonjs0116@gmail.com>
JoonsooWon
force-pushed
the
issues_4613_container_rename_linux_test.go
branch
from
73c6de1 to
3ffd43f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
related : #4613