Skip to content

Refactor container_rename_linux_test.go to use Tigron #4687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChengyuZhu6 merged 1 commit into from
Jan 17, 2026
Merged

Refactor container_rename_linux_test.go to use Tigron #4687

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
161 changes: 131 additions & 30 deletions cmd/nerdctl/container/container_rename_linux_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,42 +19,143 @@ package container
import (
"testing"

"github.com/containerd/nerdctl/mod/tigron/expect"
"github.com/containerd/nerdctl/mod/tigron/require"
"github.com/containerd/nerdctl/mod/tigron/test"

"github.com/containerd/nerdctl/v2/pkg/testutil"
"github.com/containerd/nerdctl/v2/pkg/testutil/nerdtest"
)

func TestRename(t *testing.T) {
t.Parallel()
testContainerName := testutil.Identifier(t)
base := testutil.NewBase(t)

defer base.Cmd("rm", "-f", testContainerName).Run()
base.Cmd("run", "-d", "--name", testContainerName, testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()

defer base.Cmd("rm", "-f", testContainerName+"_new").Run()
base.Cmd("rename", testContainerName, testContainerName+"_new").AssertOK()
base.Cmd("ps", "-a").AssertOutContains(testContainerName + "_new")
base.Cmd("rename", testContainerName, testContainerName+"_new").AssertFail()
base.Cmd("rename", testContainerName+"_new", testContainerName+"_new").AssertFail()
testCase := nerdtest.Setup()

testCase.Setup = func(data test.Data, helpers test.Helpers) {
testContainerName := data.Identifier()
data.Labels().Set("containerName", testContainerName)
helpers.Ensure("run", "-d", "--name", testContainerName, testutil.CommonImage, "sleep", nerdtest.Infinity)
nerdtest.EnsureContainerStarted(helpers, testContainerName)
}

testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
testContainerName := data.Labels().Get("containerName")
helpers.Anyhow("rm", "-f", testContainerName)
helpers.Anyhow("rm", "-f", testContainerName+"_new")
}

testCase.SubTests = []*test.Case{
{
Description: "`rename` should work",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("rename", testContainerName, testContainerName+"_new")
},
Expected: test.Expects(expect.ExitCodeSuccess, nil, nil),
},
{
Description: "`rename` should have updated container name",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
return helpers.Command("ps", "-a")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
testContainerName := data.Labels().Get("containerName")
return test.Expects(expect.ExitCodeSuccess, nil, expect.Contains(testContainerName+"_new"))(data, helpers)
},
},
{
Description: "`rename` should fail to rename not existing container",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("rename", testContainerName, testContainerName+"_new")
},
Expected: test.Expects(1, nil, nil),
},
{
Description: "`rename` should fail to rename to existing name",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("rename", testContainerName+"_new", testContainerName+"_new")
},
Expected: test.Expects(1, nil, nil),
},
}

testCase.Run(t)
}

func TestRenameUpdateHosts(t *testing.T) {
t.Parallel()
testutil.DockerIncompatible(t)
testContainerName := testutil.Identifier(t)
base := testutil.NewBase(t)

defer base.Cmd("rm", "-f", testContainerName).Run()
base.Cmd("run", "-d", "--name", testContainerName, testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
base.EnsureContainerStarted(testContainerName)

defer base.Cmd("rm", "-f", testContainerName+"_1").Run()
base.Cmd("run", "-d", "--name", testContainerName+"_1", testutil.CommonImage, "sleep", nerdtest.Infinity).AssertOK()
base.EnsureContainerStarted(testContainerName + "_1")

defer base.Cmd("rm", "-f", testContainerName+"_new").Run()
base.Cmd("exec", testContainerName, "cat", "/etc/hosts").AssertOutContains(testContainerName + "_1")
base.Cmd("rename", testContainerName, testContainerName+"_new").AssertOK()
base.Cmd("exec", testContainerName+"_new", "cat", "/etc/hosts").AssertOutContains(testContainerName + "_new")
base.Cmd("exec", testContainerName+"_1", "cat", "/etc/hosts").AssertOutContains(testContainerName + "_new")
testCase := nerdtest.Setup()
testCase.Require = require.Not(nerdtest.Docker)

testCase.Setup = func(data test.Data, helpers test.Helpers) {
testContainerName := data.Identifier()
data.Labels().Set("containerName", testContainerName)

helpers.Ensure("run", "-d", "--name", testContainerName, testutil.CommonImage, "sleep", nerdtest.Infinity)
helpers.Ensure("run", "-d", "--name", testContainerName+"_1", testutil.CommonImage, "sleep", nerdtest.Infinity)

nerdtest.EnsureContainerStarted(helpers, testContainerName)
nerdtest.EnsureContainerStarted(helpers, testContainerName+"_1")
}

testCase.Cleanup = func(data test.Data, helpers test.Helpers) {
testContainerName := data.Labels().Get("containerName")
helpers.Anyhow("rm", "-f", testContainerName)
helpers.Anyhow("rm", "-f", testContainerName+"_1")
helpers.Anyhow("rm", "-f", testContainerName+"_new")
}

testCase.SubTests = []*test.Case{
{
Description: "check '/etc/hosts' for sibling container",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("exec", testContainerName, "cat", "/etc/hosts")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
testContainerName := data.Labels().Get("containerName")
return test.Expects(expect.ExitCodeSuccess, nil, expect.Contains(testContainerName+"_1"))(data, helpers)
},
},
{
Description: "rename container",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("rename", testContainerName, testContainerName+"_new")
},
Expected: test.Expects(expect.ExitCodeSuccess, nil, nil),
},
{
Description: "check '/etc/hosts' for renamed container",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("exec", testContainerName+"_new", "cat", "/etc/hosts")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
testContainerName := data.Labels().Get("containerName")
return test.Expects(expect.ExitCodeSuccess, nil, expect.Contains(testContainerName+"_new"))(data, helpers)
},
},
{
Description: "check sibling's '/etc/hosts' for renamed container",
NoParallel: true,
Command: func(data test.Data, helpers test.Helpers) test.TestableCommand {
testContainerName := data.Labels().Get("containerName")
return helpers.Command("exec", testContainerName+"_1", "cat", "/etc/hosts")
},
Expected: func(data test.Data, helpers test.Helpers) *test.Expected {
testContainerName := data.Labels().Get("containerName")
return test.Expects(expect.ExitCodeSuccess, nil, expect.Contains(testContainerName+"_new"))(data, helpers)
},
},
}

testCase.Run(t)
}