Run: don't try to encode SystemContext with json#6650
Merged
Luap99 merged 1 commit intocontainers:mainfrom Jan 22, 2026
Merged
Conversation
nalind
added
the
No New Tests
dosubot
bot
added
the
size:XS
Luap99
reviewed
Jan 22, 2026
Don't expect to be able to encode a SystemContext as JSON, because it will trigger an encoding error if fields which can't be encoded are set. Signed-off-by: Nalin Dahyabhai <nalin@redhat.com>
nalind
force-pushed
the
system-context-not-json
branch
from
c74dbe8 to
cd0d003
Compare
mtrmac
reviewed
Jan 22, 2026
Contributor
mtrmac
left a comment
mtrmac
left a comment
There was a problem hiding this comment.
ACK to the extent “this clearly avoids the failure path” but I didn’t check whether anything needs that value to be carried over JSON.
This was referenced Jan 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind other
What this PR does / why we need it:
Don't expect to be able to encode a
SystemContextas JSON, because it will trigger an encoding error if fields which can't be encoded are set.How to verify it
podman has a "podman build - basic test" test that should be fixed by this.
Which issue(s) this PR fixes:
None
Special notes for your reviewer:
Does this PR introduce a user-facing change?