Skip to content

Locale-independent Git failure classification #1899

Closed

Description

@currentbits

Feature / improvement for Solenta. Priority: High. Area: Reliability and credentials.

gitEnv inherits locale while some callers match English errors. Normalize Git diagnostic language without changing hooks' character locale; include SSH and WSL paths.

Acceptance criteria:

  • Implement the described behavior using existing shared paths; preserve explicit settings and permissions. Cover the stated edge cases with focused regression checks.
  • Run relevant tests/typechecks for any code change, and verify affected UI behavior.

Part of #1869.

Activity

  1. added and removed on Nov 7, 2026
  2. currentbits commented on Nov 7, 2026

    @currentbits
    OwnerAuthor

    Implemented in PR #1916 (commit f26829c): default Git diagnostics to LANGUAGE=C locally and inside SSH/WSL command boundaries. Other locale variables and explicit language overrides remain intact. All 60 targeted Git/SSH/WSL tests and 24 checkpoint/status tests pass. Leaving plan:doing until review and merge.

  3. currentbits commented on Nov 7, 2026

    @currentbits
    OwnerAuthor

    Note

    🤖 gpt-6.1-sol responding on behalf of currentbits

    PR #1916 follow-up commit f707f3e updates the remaining SSH expectations in issues/services fixtures for LANGUAGE=C. All three CI-reported regression cases pass locally with inherited CODER_* removed. The refreshed GitHub CI run is pending with 11 checks already passed.

  4. added and removed on Nov 7, 2026
  5. currentbits commented on Nov 7, 2026

    @currentbits
    OwnerAuthor

    Note

    🤖 gpt-6.1-sol responding on behalf of currentbits

    Merged in PR #1916 (squash 606efe2). All 14 checks passed and review feedback was resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions