Repository navigation
perf(paths): one files:resolve call per batch, thread root resolved once (#1475) - #1484
Merged
currentbits merged 2 commits intoOct 5, 2026
Merged
Conversation
Each path used to repeat store.getThread (a linear scan) and getProject. Raise the per-call cap from 80 to 500 so a batched renderer request fits. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…1475) useResolvedMap asked once in render and again in its effect, per block, so opening a large thread sent hundreds of files:resolve IPCs. The provider now queues uncached paths for a microtask flush, dedupes in-flight lookups, and does not cache a failed lookup. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This was referenced Oct 6, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #1475, main-process finding 5. Opening one large thread fired 424 separate
files:resolveIPCs, costing 131 ms of main-process time during first render.What changed
PathLinkProviderqueues every component's lookups and flushes them in a microtask as one resolver call, chunked at 500 paths. It dedupes in-flight paths, and a generation counter stops a thread switch from caching the previous thread's results. Failed lookups aren't cached, so a later render retries them.files:resolveresolves the thread root once per call instead of once per path (tryResolveWorkspaceFiles). The per-call cap rises from 80 to 500, matching the renderer's chunk size.Verified independently. Old and new handlers were compared on a clone of the real store, using the largest 40 transcripts and every path-like token in them (8,249 paths):
existsSync.Suites:
mcp-inject). All of those pass when re-run on their own: 380 of 380 renderer tests and 13 of 13 inmcp-inject. The electron suite otherwise passed 4144 tests.🤖 Generated with Claude Code