Repository navigation
test(paths): fix main: remount Markdown in the failed-lookup retry test (#1475) - #1485
Merged
Merged
Conversation
#1483 made Markdown's components map stable, so a same-path rerender keeps the mounted link and its settled lookup; the old per-render map remounted it, which is the only reason the second resolver call happened. Main went red on all three OSes once #1483 and #1484 both landed. The provider contract under test (a failed lookup is not cached) is unchanged: keyed remount, and a mutation that caches failures still fails the test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main has been red on all three platforms since #1483 and #1484 both merged. Only one test fails:
PathLinkProvider batching > does not cache a failed lookup.Cause: #1483 made Markdown's
componentsmap a stable module-level constant. A rerender with the same path now keeps the mounted link and its settled lookup. The old per-render map remounted it, and that remount is the only reason the test saw a second resolver call.Fix: remount Markdown with
key={text}in that one test. What the test checks is unchanged: the provider must not cache a failed lookup.Product behaviour: same as before both PRs. A failed lookup has only ever been retried when the link remounts.
🤖 Generated with Claude Code