Skip to content

test(paths): fix main: remount Markdown in the failed-lookup retry test (#1475) #1485

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
currentbits merged 1 commit into from
Oct 6, 2026
Merged

test(paths): fix main: remount Markdown in the failed-lookup retry test (#1475) #1485

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion test/markdown.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,7 +233,11 @@ describe("PathLinkProvider batching (#1475)", () => {
}}
openPath={() => {}}
>
<Markdown text={text} />
{/* key: remount so the link asks again. Markdown keeps a stable
components map (#1483), so a same-path rerender reuses the
mounted link and its settled lookup; the provider contract under
test is only that the failure was not cached. */}
<Markdown key={text} text={text} />
</PathLinkProvider>
);
const m = await mount(tree("see `src/foo.ts`"));
Expand Down
Loading