Repository navigation
Skip optional CUDA downloads in CPU-only CI - #1952
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 8, 2026
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CPU-only CI can fail before any tests run because pinned
onnxruntime-node@1.21.0downloads its optional Linux x64 CUDA archive even whennvccis absent. Both the test job and headless smoke job on #1924 failed there with HTTP 504.Pass the package's supported
--onnxruntime-node-install-cuda=skipoption only to the existing memory-server installs intest.yml'stestandheadless-linuxjobs. Memory embeddings explicitly select CPU/q8, and the npm tarball already includes the native CPU runtime. The ordinarysmokejob does not install memory-server and needs no change. See the pinned upstream installer.Production package installs, lockfiles, and
server-bundle.ymlremain unchanged. The bundle workflow builds redistributable archives, so it retains the default GPU-capable install even on CPU runners. All memory tests and all four native server build/worktree/PTY smoke targets remain intact; no retries or test exclusions are added.Validation:
nvcc(stopped at a 120-second validation limit). A separate clean install with the exact updated workflow command succeeds with all lifecycle scripts enabled and no GPU download.package-server.sh darwin-arm64build andsmoke-server-bundle.jspass: bundled Node 24.22.2, server boot, thread in a worktree, and real PTY. Other native architectures remain covered by the unchanged CI matrix.git diff --checkand actionlint workflow validation pass. Full ShellCheck reports the same pre-existing SC2086 warning as the base workflow.Fixes #1950.
GitHub Actions on this head: all three ordinary smoke jobs pass, as do Linux x64 Xvfb and both Linux ARM headless boots. The Ubuntu test job and x64 ozone job fail earlier in root
npm ci, downloading Electron with HTTP 504/502, before reaching memory-server. macOS/Windows full test jobs were still running at the last check. These separate Electron download failures are outside this CUDA-only fix; no retries or weakened tests were added.Created with GPT-6.1 Sol in Codex (Solenta).