Repository navigation
Cache verified Electron distributions in CI - #1957
Merged
Merged
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This was referenced Nov 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Electron's postinstall download can fail with HTTP 504 before any tests run, even after the npm cache restores successfully (for example job 128708386644). npm caches package tarballs, while the locked Electron installer downloads its distribution separately.
Add a shared CI install action that caches only Electron distribution archives under an explicit runner-temp path, keyed exactly by the locked Electron version, native Node platform and architecture. Restore, installer and save use that same path on Windows, macOS and Linux, independent of HOME/LOCALAPPDATA/XDG_CACHE_HOME. Save immediately after successful npm ci so later suite failures do not discard a verified download. Cover test, smoke, both Linux headless architectures and server-bundle installs; action edits trigger the bundle workflow too.
The pinned electron@35.7.5 / @electron/get@2.0.3 installer still downloads from official GitHub releases and verifies fresh and cached ZIPs against checksums bundled in its npm-integrity-pinned package. No mirror, broad restore keys, binary-download skip or test/smoke changes. The separate ONNX CUDA fix #1952 is untouched. Cold or evicted caches still need the upstream endpoint; caches become available to sibling feature branches through main after merge.
Validation:
Tracks #1955; leave open until merged. This branch is based on main and contains only the CI cache change.
Created with GPT-6.1 Sol in Codex.