Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Slightly bumps the relative tolerances for a few tests to address the flaky CI behavior seen in #51, #53, #58, and #59.
Locally, for new venvs with the same os, python, numpy, scipy, and openblas versions, I can consistently reproduce the test failures on one machine (AMD cpu) but not another (Intel cpu, not using mkl), so these flaky tests may just have a small architecture dependence? When the tests fail, both on the CI and locally, they always produce the same output, so it's not like the output is random. Not worth devoting more time to this since simply bumping the rtol by half a magnitude addresses all failures.
Type of Pull Request
Pull Request Checklist
if applicable.