Skip to content

TEST: Bump rtols to fix flaky tests #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
derb12 merged 1 commit into from
Feb 1, 2026
Merged

TEST: Bump rtols to fix flaky tests #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion tests/test_spline_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -620,7 +620,7 @@ def test_pspline_lam_extremes(data_fixture, diff_order, allow_lower, spline_degr
# and both larger num_knots and larger diff_orders need larger lam for it to be a
# polynomial, so have to reduce the relative tolerance; num_knots has a larger effect
# than diff_order, so base the rtol on it
rtol = {50: 5e-4, 501: 5e-3}[num_knots]
rtol = {50: 1e-3, 501: 5e-3}[num_knots]
assert_allclose(output, polynomial_fit, rtol=rtol, atol=1e-10)

# for lam ~ 0, should just approximate the an interpolating spline
Expand Down
4 changes: 2 additions & 2 deletions tests/test_whittaker.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -324,7 +324,7 @@ def test_sparse_comparison(self, diff_order, eta):
self.y, lam=lam, eta=eta, diff_order=diff_order, max_iter=max_iter, tol=tol
)

assert_allclose(banded_output, sparse_output, rtol=1e-6, atol=1e-10)
assert_allclose(banded_output, sparse_output, rtol=1.5e-6, atol=1e-10)


class TestIArPLS(WhittakerTester):
Expand Down Expand Up @@ -445,7 +445,7 @@ def test_sparse_comparison(self, diff_order, asymmetric_coef):
asymmetric_coef=asymmetric_coef
)[0]

rtol = {2: 1e-4, 3: 2e-4}[diff_order]
rtol = {2: 1.5e-4, 3: 3e-4}[diff_order]
assert_allclose(banded_output, sparse_output, rtol=rtol, atol=1e-8)


Expand Down