Skip to content

removed security demo which requires cuda#2251

Merged
paul-nechifor merged 1 commit into
mainfrom
fix/macos/unitreego2_agentic
May 26, 2026
Merged

removed security demo which requires cuda#2251
paul-nechifor merged 1 commit into
mainfrom
fix/macos/unitreego2_agentic

Conversation

@spomichter

@spomichter spomichter commented May 26, 2026

Copy link
Copy Markdown
Contributor

Problem

Unitree go2 agentic has been broken on all CUDA machines due to SecurityModule related demo

Closes DIM-XXX

Solution

How to Test

uv run dimos --replay run unitree-go2-agentic on macos

Contributor License Agreement

  • I have read and approved the CLA.

@spomichter spomichter marked this pull request as ready for review May 26, 2026 15:33
@greptile-apps

greptile-apps Bot commented May 26, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This PR removes the CUDA-dependent SecurityModule from the unitree_go2_spatial blueprint, along with its associated GO2Connection import that was only needed to supply camera info to that module.

  • The SecurityModule.blueprint(camera_info=GO2Connection.camera_info_static) call is dropped from the autoconnect chain, and both now-unused imports are cleaned up.
  • The remaining blueprint (unitree_go2 + SpatialMemory + PerceiveLoopSkill) is left intact and unchanged.

Confidence Score: 5/5

A clean removal of a CUDA-dependent demo module with no logic changes to the remaining components.

The change is a straightforward import and call-site deletion. The remaining blueprint compiles correctly and its three components are unaffected. No logic is altered, no state is dropped, and no side effects are introduced.

No files require special attention.

Important Files Changed

Filename Overview
dimos/robot/unitree/go2/blueprints/smart/unitree_go2_spatial.py Removes SecurityModule and GO2Connection imports and the SecurityModule.blueprint() call from the spatial blueprint, leaving a clean 3-component autoconnect chain.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[unitree_go2_spatial blueprint] --> B[autoconnect]
    B --> C[unitree_go2]
    B --> D[SpatialMemory.blueprint]
    B --> E[PerceiveLoopSkill.blueprint]
    B --> F[global_config n_workers=8]

    style G fill:#f9f9f9,stroke:#ccc
    G[REMOVED: SecurityModule.blueprint\ncamera_info=GO2Connection.camera_info_static]
Loading

Reviews (1): Last reviewed commit: "removed security demo which requires cud..." | Re-trigger Greptile

@codecov

codecov Bot commented May 26, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@paul-nechifor paul-nechifor enabled auto-merge (squash) May 26, 2026 16:49
@paul-nechifor paul-nechifor merged commit 87798fb into main May 26, 2026
31 of 35 checks passed
@paul-nechifor paul-nechifor deleted the fix/macos/unitreego2_agentic branch May 26, 2026 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants