Yc/fix macos#2255
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1985fb6ad3
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| stdout=subprocess.PIPE, | ||
| stderr=subprocess.PIPE, |
There was a problem hiding this comment.
This change sets the MuJoCo child process stdout/stderr to PIPE but the parent does not read either stream while waiting for readiness. If the child emits enough logs during startup, the OS pipe buffer can fill and block the child before shared memory is marked ready, causing startup to hang or time out. Use inherited stdout/stderr, a file sink, or concurrent readers instead of leaving both pipes undrained.
Useful? React with 👍 / 👎.
| Type=simple | ||
| WorkingDirectory=/opt/dimos | ||
| EnvironmentFile=/opt/dimos/.env | ||
| ExecStart=/opt/dimos/.venv/bin/dimos run unitree-go2-agentic |
There was a problem hiding this comment.
The unit file is labeled as the guide-robot service, but ExecStart runs unitree-go2-agentic rather than the new guide stack. That blueprint does not include the guide-specific modules (e.g., blind-assistant skills and agent_state stream), so deploying this service will boot a stack incompatible with the new phone/web flow.
Useful? React with 👍 / 👎.
| @@ -0,0 +1,2 @@ | |||
| NEXT_PUBLIC_DIMOS_API=https://cecilia-apple-m3-max.ratfish-drum.ts.net:8443 | |||
| NEXT_PUBLIC_DIMOS_TOKEN=42c7d88186fe9ee5364585f018d2d18e | |||
There was a problem hiding this comment.
This commit checks in a concrete backend URL and bearer token in a tracked .env.local. Because this token is used to authorize command/query endpoints, publishing it in-repo creates immediate credential exposure and also bakes environment-specific secrets into generated client artifacts committed in the same change. Replace with placeholders and rotate the leaked token.
Useful? React with 👍 / 👎.
2 participants
remove cude relevant pkgs