Repository navigation
Conversation
|
Azure Pipelines: Successfully started running 6 pipeline(s). 9 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
am11
force-pushed
the
chore/consolidate-package-rids
branch
5 times, most recently
from
November 1, 2026 03:49
461d241 to
fda6ffe
Compare
am11
force-pushed
the
chore/consolidate-package-rids
branch
from
November 1, 2026 04:06
fda6ffe to
354bbd4
Compare
This was referenced Nov 3, 2026
Closed
jkoritzinsky
requested changes
Nov 3, 2026
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Adeel Mujahid <3840695+am11@users.noreply.github.com>
3 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new linux-bionic-* entries make ILCompiler and ILAsm/ILDAsm restores request packages that Bionic builds do not produce, requiring tool-specific RID filtering.
2 open issues
What changed in this PR
Consolidates package runtime identifier (RID) definitions under eng/, sharing them across installer and CoreCLR tool packaging.
Changes:
- Introduces a shared RID list with platform and official-build metadata.
- Replaces separate runtime and ILCompiler lists with shared imports.
- Adds the shared file to ILAsm pipeline triggers.
| File | Description |
|---|---|
src/installer/pkg/projects/netcoreappRIDs.props |
Removes the separate runtime RID list. |
src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/ILCompilerRIDs.props |
Removes the ILCompiler-specific RID list. |
src/installer/pkg/projects/Microsoft.DotNet.ILCompiler/Directory.Build.props |
Removes the ILCompiler RID-list override. |
src/installer/pkg/projects/Directory.Build.props |
Uses shared RIDs for packaging and restore selection. |
src/coreclr/.nuget/package-rids.props |
Uses shared RIDs for CoreCLR tool packages. |
eng/pipelines/coreclr/ilasm.yml |
Triggers validation when the shared list changes. |
eng/PackageRids.props |
Defines shared RIDs, metadata, and current-build additions. |
Review effort: Balanced
Member
Author
|
@jkotas Copilot was off on the bionic RID comments. Those gaps were from ports adding RIDs as needed, not an intentional omit, so the shared list stays as-is. |
jkotas
approved these changes
Nov 7, 2026
jkotas
left a comment
jkotas
left a comment
Member
There was a problem hiding this comment.
Looks good to me, but I’m not that familiar with the official builds. I will leave it to @jkoritzinsky to signoff and merge.
This was referenced Nov 12, 2026
Open
3 tasks
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.