Repository navigation
Fix XUnitLogChecker single-file publishing - #137366
Conversation
Enable the apphost for the checker's single-file publish mode so CoreCLR Linux Bionic builds do not fail with NETSDK1067. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
Tagging subscribers to this area: @agocke, @dotnet/ilc-contrib |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
2 similar comments
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
|
@akoeplinger, just curious, why don't we use PublishAot on linux-bionic? given it isn't listed as unsupported OS If linux-musl-loongarch64, openbsd-x64 type of community platforms even publish it with AOT, linux-bionic-arm64 sounds it should too. |
|
@am11 good question, I haven't looked deeper into it, feel free to do if you want. I'll merge this to unblock the pipeline. |
It's excluded elsewhere: I gave that a try in #137386, but it couldn't find runtime pack or something like that. |
The platform, for which we don't have MSFT's published runtime-packs, should be considered a community platform: #136770 ( Also, in another thread #106748 (comment), we were questioning keeping linux-bionic in addition to android is necessary. Unlike linux-musl multiple distros, bionic libc is only used by Android so libc abstraction doesn't make much sense for 1:1 relationship. For our purposes, bionic libc == Android with !FeatureGooglePlayIntegration (which could just be a (trimable) feature switch). |
We do build it and officially support it (I guess the official support status is still "experimental"): https://www.nuget.org/packages/Microsoft.NETCore.App.Runtime.NativeAOT.linux-bionic-arm64. This is some infra misconfiguration. |
|
@akoeplinger, I was questioning the RID justification: why do we need |
Fix XUnitLogChecker publishing in the CoreCLR Linux Bionic lane enabled by #137338.
The checker inherits
UseAppHost=falsefrom the runtime test projects, but its non-NativeAOT publish mode enables trimming and single-file publishing. The SDK consequently infers a self-contained application and fails with NETSDK1067. Enable the apphost locally when the checker selects single-file publishing, leaving NativeAOT and explicit framework-dependent publishing unchanged. No platform support guards or test coverage are disabled.Validation:
linux-bionic-x64andlinux-bionic-arm64; verified both ELF outputs use/system/bin/linker64.Local validation used the installed SDK
12.0.100-alpha.1.26516.101, allowed byglobal.jsonroll-forward, rather than CI's pinned SDK. Bionic binaries were not executed on the macOS host, and the full runtime pipeline was not run locally.Note
This pull request description and code change were generated with GitHub Copilot.