[NativeAot] Fixing Resources.Reader and ComponentModel tests#72497
Merged
LakshanF merged 3 commits intodotnet:mainfrom Jul 20, 2022
Merged
[NativeAot] Fixing Resources.Reader and ComponentModel tests#72497LakshanF merged 3 commits intodotnet:mainfrom
LakshanF merged 3 commits intodotnet:mainfrom
Conversation
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/ComponentTests.cs
Outdated
Show resolved
Hide resolved
Contributor
Author
|
/azp run runtime-extra-platforms |
|
Azure Pipelines successfully started running 1 pipeline(s). |
MichalStrehovsky
approved these changes
Jul 20, 2022
| [Fact] | ||
| [ActiveIssue("https://github.com/dotnet/runtime/issues/51833", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))] | ||
| // Trimming, including NativeAot, will set CustomResourceTypesSupport to false | ||
| [ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))] |
Member
There was a problem hiding this comment.
It might make sense to introduce yet another PlatformDetection constant for CustomResourceTypesSupport like Marek suggested in #51833 (comment).
Contributor
Author
There was a problem hiding this comment.
I couldn't see any failures in extra-pipeline related to this and will postpone this ask (the nativeaot rolling runs passed
Member
There was a problem hiding this comment.
The question was mostly if we ever introduce form factors that trim and don't enable this, or form factors that enable this but don't trim. I agree it can be postponed until then. We would have a test hole if the former happens, but it's unlikely.
This was referenced Jul 20, 2022
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Excluded a resource test scenario that uses custom resource type support and added the
ComponentTypeto therd.xmlfile for aComponentModeltest (tagged the scenario with the issue #72494)