Skip to content

[NativeAot] Fixing Resources.Reader and ComponentModel tests #72497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
LakshanF merged 3 commits into from
Jul 20, 2022
Merged

[NativeAot] Fixing Resources.Reader and ComponentModel tests #72497

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
e33c175
Fixing Resources.Reader and ComponentModel tests
LakshanF Jul 19, 2022
44b0702
enable the tests in proj file
LakshanF Jul 19, 2022
a677f32
FB
LakshanF Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions src/libraries/Common/tests/TestUtilities/System/PlatformDetection.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,6 +138,7 @@ private static bool GetLinqExpressionsBuiltWithIsInterpretingOnly()
#endif

public static bool IsInvokingStaticConstructorsSupported => !IsNativeAot;
public static bool IsInvokingFinalizersSupported => !IsNativeAot;

public static bool IsMetadataUpdateSupported => !IsNativeAot;

Expand Down
2 changes: 1 addition & 1 deletion src/libraries/System.ComponentModel.Primitives/tests/System/ComponentModel/ComponentTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,7 +218,7 @@ public void Dispose_InvokeDisposingCannotRaiseEvents_DoesNotCallHandler(bool dis
Assert.Equal(0, callCount);
}

[Fact]
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsInvokingFinalizersSupported))]
public void Finalize_Invoke_DoesNotCallDisposedEvent()
{
var component = new SubComponent();
Expand Down
4 changes: 2 additions & 2 deletions src/libraries/System.Resources.Reader/tests/ResourceReaderUnitTest.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -259,8 +259,8 @@ public static void Exception_Enumerator_Value()
});
}

[Fact]
[ActiveIssue("https://github.com/dotnet/runtime/issues/51833", typeof(PlatformDetection), nameof(PlatformDetection.IsBuiltWithAggressiveTrimming), nameof(PlatformDetection.IsBrowser))]
// Trimming, including NativeAot, will set CustomResourceTypesSupport to false
[ConditionalFact(typeof(PlatformDetection), nameof(PlatformDetection.IsNotBuiltWithAggressiveTrimming))]
Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might make sense to introduce yet another PlatformDetection constant for CustomResourceTypesSupport like Marek suggested in #51833 (comment).

Copy link
Copy Markdown
Contributor Author

@LakshanF LakshanF Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't see any failures in extra-pipeline related to this and will postpone this ask (the nativeaot rolling runs passed

Copy link
Copy Markdown
Member

@MichalStrehovsky MichalStrehovsky Jul 20, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The question was mostly if we ever introduce form factors that trim and don't enable this, or form factors that enable this but don't trim. I agree it can be postponed until then. We would have a test hole if the former happens, but it's unlikely.

public static void ReadV1Resources()
{
//NOte: The below ByteStream was generated by V1 framework resource writer from the below dictionary
Expand Down
2 changes: 0 additions & 2 deletions src/libraries/tests.proj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -493,7 +493,6 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.CodeDom\tests\System.CodeDom.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.Composition\tests\System.ComponentModel.Composition.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.Composition.Registration\tests\System.ComponentModel.Composition.Registration.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.Primitives\tests\System.ComponentModel.Primitives.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.ComponentModel.TypeConverter\tests\System.ComponentModel.TypeConverter.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Composition\tests\System.Composition.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Composition.Hosting\tests\System.Composition.Hosting.Tests.csproj" />
Expand Down Expand Up @@ -530,7 +529,6 @@
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.Extensions\tests\System.Reflection.Extensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Reflection.TypeExtensions\tests\System.Reflection.TypeExtensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.Extensions\tests\System.Resources.Extensions.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.Reader\tests\System.Resources.Reader.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Resources.ResourceManager\tests\System.Resources.ResourceManager.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime\tests\NlsTests\System.Runtime.Nls.Tests.csproj" />
<ProjectExclusions Include="$(MSBuildThisFileDirectory)System.Runtime.Extensions\tests\System.Runtime.Extensions.Tests.csproj" />
Expand Down