Enable nullability in DesignerActionUI#10137
Merged
lonitra merged 7 commits intodotnet:mainfrom Oct 27, 2023
Merged
Conversation
halgab
force-pushed
the
DesignerActionUI-null
branch
from
f99b6bd to
0436535
Compare
Contributor
Author
|
Test failure looks unrelated. The failing test is not a design test |
LeafShi1
reviewed
Oct 19, 2023
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Outdated
Show resolved
Hide resolved
src/System.Windows.Forms.Design/src/System/ComponentModel/Design/DesignerActionUI.cs
Show resolved
Hide resolved
Tanya-Solyanik
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
Tanya-Solyanik
added
the
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
lonitra
approved these changes
Oct 26, 2023
| _cancelClose = false; | ||
| e.Cancel = true; | ||
| Debug.WriteLineIf(DropDownVisibilityDebug.TraceVerbose, "cancel close prepopulated"); | ||
| DropDownVisibilityDebug.TraceVerbose("cancel close prepopulated"); |
Contributor
Author
There was a problem hiding this comment.
Well, it's part of the job 😃. If I hadn't changed those, we would have nullability warnings in release
lonitra
added
the
ready-to-merge
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
ghost
removed
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Extracted from #9367
Proposed changes
DesignerActionUIDesignerActionKeyboardBehaviorMicrosoft Reviewers: Open in CodeFlow