Enable nullability in DesignerActionService and DesignerActionUIService by halgab · Pull Request #9367 · dotnet/winforms

halgab · 2023-06-25T14:14:38Z

Proposed changes

Enable nullability in DesignerActionService, DesignerActionUIService, and all the internal code these classes use: DesignerActionUI, DesignerActionPanel and SelectionManager

Microsoft Reviewers: Open in CodeFlow

dreddy-work · 2023-06-26T22:39:30Z

Check the build failures.

...dows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.EditorPropertyLine.cs

dreddy-work · 2023-07-03T17:48:42Z

...ws.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.CheckBoxPropertyLine.cs

    private sealed class CheckBoxPropertyLine : PropertyLine
    {
-        private CheckBox _checkBox;
+        private CheckBox? _checkBox;


can this be assigned in constructor or currently, any of its properties changed from constructor to current initialization? Wanted to see if we can avoid ! all over.

I attempted a big shake-up of the code to avoid that, and got afraid it was too big of a change, I can try again and let you assess if it's too ambitious.

The problem I remember adding though is that the method AddControls is only called through GetControls, which is called only when we end up actually using the created Line objects.

Try in a separate PR and see if we can take it independently before this.

My idea was this. I know I need to move some classes around before this is good to merge, but I wanted your opinion on it because it feels pretty heavy. And I don't know if I should bring the PR to this repo instead?

I can not access that link. You can push as draft PRs if you have draft changes. I will make sure me/someone on the team take a look later this week and share next steps.

I opened #9422. The end result is a lot simpler than what I thought it would be.

dreddy-work · 2023-07-03T17:51:16Z

...dows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.EditorPropertyLine.cs

    {
-        private EditorButton _button;
-        private UITypeEditor _editor;
+        private EditorButton? _button;


same with _button. if we ensure dispose of it if not used, i think we can avoid !

LeafShi1 · 2023-07-19T06:29:08Z

...ows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.TextBoxPropertyLine.cs

+                if (EditControl is TextBox)
                {
                    specialPadding = 2;
                }


This part can use ternary expressions to make the code more concise
int specialPadding = EditControl is TextBox ? 2 : 0;

halgab · 2023-07-19T20:26:27Z

Thanks for your review @LeafShi1. Did you get a chance to have a look at the version in #9422?

halgab · 2023-07-20T13:33:10Z

I applied review feedback, rebased to solve conflicts, and mirrored the changes in #9422. For the record, I think #9422 is the better way to go here.

`IWindowsFormsEditorService.DropDownControl` now expects an non-null `Control` as argument

ghost · 2023-10-17T01:01:10Z

This submission has been automatically marked as stale because it has been marked as requiring author feedback but has not had any activity for 14 days.

It will be closed if no further activity occurs within 7 days of this comment.

halgab · 2023-10-20T08:03:15Z

This is superseded by numerous PRs that break down the work started here

ghost assigned halgab Jun 25, 2023

ghost added the area-NRT label Jun 25, 2023

halgab changed the title ~~Enable nullability in DesignerActionService, DesignerActionUIService, DesignerActionUI and SelectionManager~~ Enable nullability in DesignerActionService and DesignerActionUIService Jun 25, 2023

ghost added the draft draft PR label Jun 25, 2023

halgab force-pushed the DesignerActionService-null branch 3 times, most recently from 3670e7c to 84c7093 Compare June 26, 2023 10:32

halgab marked this pull request as ready for review June 26, 2023 10:53

halgab requested a review from a team as a code owner June 26, 2023 10:53

ghost removed the draft draft PR label Jun 26, 2023

halgab force-pushed the DesignerActionService-null branch from 84c7093 to 1002393 Compare June 26, 2023 20:10

dreddy-work added the waiting-author-feedback The team requires more information from the author label Jun 26, 2023

Tanya-Solyanik requested review from Epica3055, LeafShi1 and SimonZhao888 June 27, 2023 05:48

ghost removed the waiting-author-feedback The team requires more information from the author label Jun 27, 2023

halgab force-pushed the DesignerActionService-null branch from fb48dbf to cbaae24 Compare June 27, 2023 09:00

dreddy-work reviewed Jun 30, 2023

View reviewed changes

...dows.Forms.Design/src/System/ComponentModel/Design/DesignerActionPanel.EditorPropertyLine.cs Outdated Show resolved Hide resolved

dreddy-work suggested changes Jul 3, 2023

View reviewed changes

ghost added waiting-author-feedback The team requires more information from the author and removed waiting-author-feedback The team requires more information from the author labels Jul 3, 2023

This was referenced Jul 3, 2023

Refactor DesignerActionPanel Line object creation halgab/winforms#1

Closed

Designer action panel line refactoring #9422

Closed

LeafShi1 reviewed Jul 19, 2023

View reviewed changes

LeafShi1 previously approved these changes Jul 19, 2023

View reviewed changes

halgab added 3 commits July 20, 2023 15:19

move TraceSwitchExtensions

924415a

Update MemberDescriptorExtensions.cs

540e207

annotate DesignerActionService

abe2fbb

halgab added 5 commits July 20, 2023 15:19

annotate DesignerActionUIService

c327222

annotate DesignerActionUI

b3044fb

annotate SelectionManager

1ec76eb

annotate DesignerActionBehavior

8bfdc97

annotate DesignerActionPanel

1696be3

halgab dismissed LeafShi1’s stale review via ebd8a61 July 20, 2023 13:26

halgab force-pushed the DesignerActionService-null branch from 21b65e9 to ebd8a61 Compare July 20, 2023 13:26

halgab added 3 commits July 20, 2023 15:45

fix build

7be182c

update IWindowsFormsEditorService annotations

a19db12

`IWindowsFormsEditorService.DropDownControl` now expects an non-null `Control` as argument

review feedback

cbe32d1

halgab force-pushed the DesignerActionService-null branch from ebd8a61 to cbe32d1 Compare July 20, 2023 13:46

dreddy-work added the Net9.0 label Jul 21, 2023

dreddy-work added the waiting-author-feedback The team requires more information from the author label Oct 2, 2023

This was referenced Oct 10, 2023

Enable nullability in DesignerActionPanel #10088

Merged

Enable nullability in SelectionManager #10124

Merged

Enable nullability in DesignerActionBehavior #10125

Merged

ghost added the no-recent-activity label Oct 17, 2023

This was referenced Oct 17, 2023

Enable nullability in DesignerActionService #10136

Merged

Enable nullability in DesignerActionUI #10137

Merged

halgab closed this Oct 20, 2023

ghost removed waiting-author-feedback The team requires more information from the author no-recent-activity labels Oct 20, 2023

halgab deleted the DesignerActionService-null branch October 20, 2023 08:03

ghost locked as resolved and limited conversation to collaborators Nov 19, 2023

Conversation

halgab commented Jun 25, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Proposed changes

Microsoft Reviewers: Open in CodeFlow

Uh oh!

dreddy-work commented Jun 26, 2023

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

halgab commented Jul 19, 2023

Uh oh!

halgab commented Jul 20, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ghost commented Oct 17, 2023

Uh oh!

halgab commented Oct 20, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

halgab commented Jun 25, 2023 •

edited

Loading

halgab commented Jul 20, 2023 •

edited

Loading