Skip to content

Refactor DesignerActionPanel Line object creation#1

Closed
halgab wants to merge 264 commits intoDesignerActionService-nullfrom
DesignerActionPanel-line-refacto
Closed

Refactor DesignerActionPanel Line object creation#1
halgab wants to merge 264 commits intoDesignerActionService-nullfrom
DesignerActionPanel-line-refacto

Conversation

@halgab
Copy link
Copy Markdown
Owner

@halgab halgab commented Jul 3, 2023

Related to dotnet#9367

Proposed changes

  • Apply a factory pattern to Line creation so that we can create them only if we are sure we are going to use them

@halgab halgab force-pushed the DesignerActionPanel-line-refacto branch 2 times, most recently from e439dc8 to e61eca1 Compare July 4, 2023 09:28
@halgab halgab closed this Jul 4, 2023
@halgab halgab reopened this Jul 4, 2023
@halgab halgab force-pushed the DesignerActionService-null branch from 21b65e9 to ebd8a61 Compare July 20, 2023 13:26
@halgab halgab force-pushed the DesignerActionPanel-line-refacto branch from e61eca1 to 12f3ce9 Compare July 20, 2023 13:30
@halgab halgab force-pushed the DesignerActionService-null branch from ebd8a61 to cbe32d1 Compare July 20, 2023 13:46
@halgab halgab force-pushed the DesignerActionPanel-line-refacto branch from 12f3ce9 to 7512dc1 Compare July 20, 2023 13:48
Simon Zhao (Beyondsoft Corporation) and others added 22 commits July 25, 2023 17:57
[main] Update dependencies from dotnet/runtime
* Move BindToObject to a separate file

* Enable nullability in BindToObject

* Use pattern matching

* Make lManager nullable

* Make value nullable

* Use pattern matching and remove text variable
[main] Update dependencies from dotnet/runtime
* Port MonthCalendarDesigner to runtime

* Delete unnecessary namespace

* Delete redundant assertions and redundant judgment conditions

* Update MonthCalendarDesigner.cs to use file-scoped namespaces
Fixes dotnet#9464
* Fix Cursor.ToString - do not look up user-provided cursors in the well known list.
* Add test 
* Fix WinformsControlsTest not showing System.Drawing.Design editors
…ayed in properties window dotnet#5337 (dotnet#9570)

Fix items property for multiple checked list boxes should not be displayed in properties window dotnet#5337
* Update language format from ll_CC to LCID

Related to dotnet#9556

* Update xlfs.

* Update back to ll-CC format with right syntax suggested by loc.

* update xlf
* Implement ImageListDesigner

* Refactoring ImageListActionList

* Move AssemblyRef to common

* Changes from review

* Few missed changes

* Revert "Move AssemblyRef to common" and add required changes

---------

Co-authored-by: Devendar Reddy Adulla <dreddy@microsoft.com>
* Rework scrolling in PrintPreviewControl:

- replace native scrollbars with HScrollBar and VScrollBar controls;
- draw focus rectangle
- modify UIA tree to include new scrollbars.

* Reverted hiding PrintPreviewControl.TabStop property from Designer. Default value is left 'false'.

* Code cleanup:

- renamed fields to start with underscore;
- reordered class members to improve readability;
- refactored size calculation methods to avoid unnecessary casts.

* PR feedback:

- moved PrintPreviewControlAccessibleObject file to Printing folder;
- reverted adding SR resource strings;
- added FragmentNavigate method for PrintPreviewControlAccessibleObject;
- added custom AccessibleObject classes for scrollbars, to maintain UIA tree integrity;
- added unit tests.

* PR feedback:�- set scrollbars' TabStop to false

* Fixed: focus rectangle not visible when no document is previewed.

* Fixed PublicAPI.Shipped.txt
[main] Update dependencies from dotnet/arcade
[main] Update dependencies from dotnet/runtime
* Update resources

* Update missign culture.
Releasing a COM interface can lead to a call back. We need to clear fields before releasing so we don't attempt to release twice.

Add a helper and guard all of the other AgileComPointers.
dotnet-maestro bot and others added 22 commits September 7, 2023 10:21
…0903.3

Microsoft.Internal.Runtime.WindowsDesktop.Transport , Microsoft.NET.Sdk.IL , Microsoft.NETCore.App.Ref , Microsoft.NETCore.App.Runtime.win-x64 , Microsoft.NETCore.ILAsm , Microsoft.NETCore.ILDAsm , Microsoft.NETCore.Platforms , Microsoft.Win32.Registry.AccessControl , Microsoft.Win32.SystemEvents , runtime.win-x64.Microsoft.NETCore.ILAsm , runtime.win-x86.Microsoft.NETCore.ILAsm , System.CodeDom , System.ComponentModel.Composition , System.ComponentModel.Composition.Registration , System.Configuration.ConfigurationManager , System.Data.Odbc , System.Data.OleDb , System.Diagnostics.EventLog , System.Diagnostics.PerformanceCounter , System.DirectoryServices , System.DirectoryServices.AccountManagement , System.DirectoryServices.Protocols , System.IO.Packaging , System.IO.Ports , System.Management , System.Reflection.Context , System.Reflection.MetadataLoadContext , System.Resources.Extensions , System.Runtime.Caching , System.Security.Cryptography.Pkcs , System.Security.Cryptography.ProtectedData , System.Security.Cryptography.Xml , System.Security.Permissions , System.ServiceModel.Syndication , System.ServiceProcess.ServiceController , System.Speech , System.Text.Encoding.CodePages , System.Text.Encodings.Web , System.Text.Json , System.Threading.AccessControl , System.Windows.Extensions
 From Version 9.0.0-alpha.1.23430.1 -> To Version 9.0.0-alpha.1.23453.3
* Port DataGridviewDesigner to runtime dotnet#9677
* Convert AxHost fields to AgileComPointer

* Update AxHost.State methods to use pointers

* Add and use StorageType flag

* missed a setting a storage type

* address feedback

* update supportsinterface
…stem.Drawing.Common package becasue the baseline package contains assemblies built against .NET versions that will not be in support when NET9 ships.

This should be revisited when validation logic is made configurable.
…83-9153-bcececeb577b

[main] Update dependencies from dotnet/runtime
The old style folder browser was broken a few different ways:

- FolderBrowserDialog would not return the result
- FolderNameEditor would AV
- All were leaking shell handles

This adds a centralized helper to avoid these problems. This also:

- Moves the exception string to primitives
- Uses CSIDL defines and clarifies usage
- Unblocks other CSIDL values
- Uses the updated API to get the path from the PIDL

We can't use the shared dialog in FolderNameEditor as we expose dialog styles there that are not exposed in FolderBrowserDialog.

Fixes dotnet#9859
[main] Update dependencies from dotnet/runtime
[main] Update dependencies from dotnet/runtime
[main] Update dependencies from dotnet/runtime
`IWindowsFormsEditorService.DropDownControl` now expects an non-null `Control` as argument
@halgab halgab force-pushed the DesignerActionPanel-line-refacto branch 3 times, most recently from 01c374e to a746e50 Compare September 21, 2023 06:55
@halgab halgab force-pushed the DesignerActionPanel-line-refacto branch from a746e50 to 18931ea Compare September 21, 2023 07:20
@halgab halgab closed this Oct 6, 2023
@halgab halgab deleted the DesignerActionPanel-line-refacto branch October 17, 2023 07:18
@github-actions github-actions bot locked and limited conversation to collaborators Dec 6, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.