Enable nullability in TypeCodeDomSerializer#9529
Merged
lonitra merged 4 commits intodotnet:mainfrom Oct 19, 2023
Merged
Conversation
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
from
15f7e70 to
e30c929
Compare
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
2 times, most recently
from
8ba450b to
7ce195d
Compare
dreddy-work
reviewed
Jul 24, 2023
...Windows.Forms.Design/src/System/ComponentModel/Design/Serialization/TypeCodeDomSerializer.cs
Show resolved
Hide resolved
dreddy-work
reviewed
Jul 24, 2023
Member
dreddy-work
left a comment
dreddy-work
left a comment
There was a problem hiding this comment.
This is more than nullability changes. Please rebase to .NET9.0-Test branch and we will be merging it there.
dreddy-work
added
Net9.0
waiting-author-feedback
ghost
removed
the
waiting-author-feedback
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
2 times, most recently
from
ca2541d to
ede99ab
Compare
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
from
ede99ab to
a73df4a
Compare
Contributor
Author
|
Should I rebase this PR back to main? |
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
from
a73df4a to
dc15a69
Compare
Contributor
Author
I just did that, considering feature/9.0 seems to be stale @dreddy-work |
annotate CodeDomSerializationProvider annotate ComponentTypeCodeDomSerializer
halgab
force-pushed
the
TypeCodeDomSerializer_null
branch
from
63176c1 to
b5ced21
Compare
Contributor
Author
|
This one has been ready for a while @lonitra |
lonitra
added
the
ready-to-merge
ghost
removed
the
ready-to-merge
ghost
locked as resolved and limited conversation to collaborators
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Another follow-up to #9099
Proposed changes
TypeCodeDomSerializerCodeDomSerializationProviderComponentTypeCodeDomSerializerMicrosoft Reviewers: Open in CodeFlow