Rebase 26 sep #166
Open
Rebase 26 sep #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#6030) * feat(optimizer): annotate type for floor function * fix: Moved annotation from base dialect to snowflake dialect
…6049) * feat(optimizer): Annotate type for snowflake ASIN function * feat(optimizer): Annotate type for snowflake ASIN function * fix: Mapped the return type from float to double
…o#6059) * chore(optimizer): Annotate type for snowflkae SQUARE function * fix: Removed extra tests
) Co-authored-by: Jo <[email protected]>
…o#6060) * feat(optimizer): Annotate type for snowflake ATAN2 function * fix: Removed extra test
…6072) * fix(parser): support DELETE with USING and multiple VALUES * add test
…tobymao#6069) * feat(optimizer)!: Annotate type for snowflake TANH and ATAN functions * fix: updated identity.sql * fix: updated dialect files
* fix(clickhouse): Parse LIKE and NOTLIKE functions * Repurpose existing builder
…obymao#6311) * chore(exasol): implemented odbc date time literal * chore(exasol): refactored test
* fix(parser): support IS with identifier as RHS * add not test
tobymao#6309) * feat(snowflake)!: type annotation for APPROX_TOP_K_ACCUMULATE function. Tests added all dialects that support APPROX_TOP_K_ACCUMULATE * feat(snowflake)!: return type mapped to object . type annotation for APPROX_TOP_K_ACCUMULATE function. * feat(snowflake)!: return type mapped to object . type annotation for APPROX_TOP_K_ACCUMULATE function. * feat(snowflake)!: arguments names updated * Update tests/dialects/test_databricks.py --------- Co-authored-by: Vaggelis Danias <[email protected]>
…ERE AND HAVING clause in exasol dialect (tobymao#6277) * chore(exasol): implement LOCAL prefix for column aliases when using GROUP BY, HAVING and WHERE clauses * chore: refactored implementation of local qualifier for aliases * chore(exasol): refactored implementation of local qualifier for columns * chore(exasol):fixed linters
…bymao#6240) * feat(duckDB): Cast inputs (BLOB → VARCHAR) for duckDB STARTS_WITH * feat(duckDB): Addressed review comments * fix: Applied formatting * feat(duckDB): Fix code after rebase as bytestring handling was changed in generator * feat(duckdb): Added a helper method * feat(duckDB): Refactored code * feat(duckdb): Removed bytestring check, following double-cast
…mao#6312) * cast binary input to varchar for duckdb replace() * refactor to use general _cast_to_varchar helper * move varchar helper out of generator, add blob cast helper and apply to replace()
* chore(exasol): Implement day_of_week function * chore(exasol): cast the implementation to integer
Co-authored-by: Lulzim Bilali <[email protected]>
…me (tobymao#6322) Co-authored-by: Lulzim Bilali <[email protected]>
Co-authored-by: Lulzim Bilali <[email protected]>
* feat(optimizer)!: annotate type for APPROX_TOP_K * update annotated type of approx top k * remove redundant tests * make type annotation explicit, extend parsing for other dialects * revert tests and ck * single array as type for approx_top_k --------- Co-authored-by: Michael Lee <[email protected]> Co-authored-by: geooo109 <[email protected]>
…ao#6318) * preserve timezone and timestamp when generating TIMESTAMP_TRUNC expression with date granularity in duckdb * add additional testing and AtTimeZone comment
…#6320) * fix(bigquery): Do not normalize JSON fields in dot notation * Add more tests * PR Feedback 1 * Update sqlglot/optimizer/normalize_identifiers.py Co-authored-by: Jo <[email protected]> * Remove dialect flag, add more tests * Preserve string instead of identifier --------- Co-authored-by: Jo <[email protected]>
* fix(optimizer)!: more robust NULL reduction * remove newline
…AVING MAX and MIN clauses (tobymao#6325) * feat(duckDB): Add transpilation support for ANY_VALUE function with HAVING MAX and MIN clauses * feat(duckdb): Handle null case with ANY_VALUE transpilation
* fix: arg cleanup * refactor!!: rename reserved python kwargs * feat: improve performance of parser by making checks optional/faster the check for unexpected args only runs at parse time. so for 3rd party libraries or other code like the optimizer setting args or creating expressions themselves, it's never checked it or worked. moving this to unit testing only. * feat: improve update_positions performance
…o#6328) * chore(exasol): implementing date trunc, trunc relating to date and timestamp trunc to exasol date_trunc * chore(exasol): refactored implmentation using is_string to check if expression is a string and adding more test
* Transpile INITCAP with custom delimiters * Handle escaping when converting delimiters to regex expr * Clean up from review Co-authored-by: Jo <[email protected]> * PR feedback, clean up * Add presto unsupported warning, tests * Handle hive special control chars * Condense tests * address omitted exp.Initcap delim arg * use itertool.groupby for WS control chars * Fix typing --------- Co-authored-by: Jo <[email protected]>
Merge branch 'main' of https://github.com/tobymao/sqlglot into rebase-26-sep # Conflicts: # sqlglot/dialects/bigquery.py # sqlglot/dialects/dialect.py # sqlglot/dialects/hive.py # sqlglot/dialects/snowflake.py # sqlglot/dialects/spark2.py # sqlglot/optimizer/simplify.py # sqlglot/transforms.py # tests/dialects/test_mysql.py # tests/fixtures/optimizer/annotate_functions.sql # tests/test_optimizer.py
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
20 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebased the code with the toby/main sqlglot.
Fixed all the errors and ran make check.
even rebased with latest commits till 4th October 2025.
rebased on 13th oct 2025