Skip to content

Fix redirect test failure (only happening on macos)#1654

Merged
jbusecke merged 1 commit intomainfrom
macos-localhost-fix
Feb 17, 2026
Merged

Fix redirect test failure (only happening on macos)#1654
jbusecke merged 1 commit intomainfrom
macos-localhost-fix

Conversation

@jbusecke
Copy link
Contributor

When running the local rust tests I was getting:

ailures:

---- test_redirect_storage stdout ----
Error: ICError { kind: BadRedirect("Redirect Storage response must be a redirect, no location header detected"), context: SpanTrace [] }


failures:
    test_redirect_storage

test result: FAILED. 15 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 3.32s

error: test failed, to rerun pass `-p icechunk --test test_storage`
error: Recipe `test` failed on line 6 with exit code 101

Thanks to the suggestion of @li-em and some clauding I was able to fix this by replacing all occurences of localhost to 127.0.0.1 (apparently macos defaults to ::1).

@jbusecke
Copy link
Contributor Author

I am going to dabble a bit with #1656 to see if I can actually expose the bug in CI before fixing it.

@jbusecke
Copy link
Contributor Author

Since #1656 did not expose this issue I assume this is a behavior that was either changed after macos 15 or is somehow unique to my machine. So ill go to merge this anyways now.

@jbusecke jbusecke marked this pull request as ready for review February 17, 2026 21:03
@jbusecke jbusecke merged commit 796f951 into main Feb 17, 2026
17 checks passed
@jbusecke jbusecke deleted the macos-localhost-fix branch February 17, 2026 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants