Fix redirect test failure (only happening on macos)#1654
Merged
Conversation
paraseba
approved these changes
Feb 17, 2026
Contributor
Author
|
I am going to dabble a bit with #1656 to see if I can actually expose the bug in CI before fixing it. |
Contributor
Author
|
Since #1656 did not expose this issue I assume this is a behavior that was either changed after macos 15 or is somehow unique to my machine. So ill go to merge this anyways now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running the local rust tests I was getting:
Thanks to the suggestion of @li-em and some clauding I was able to fix this by replacing all occurences of
localhostto127.0.0.1(apparently macos defaults to::1).