Conversation
Contributor
Author
|
The first successful macos full test took almost 30 min: |
Contributor
Author
|
Brought the macos test down to |
Contributor
Author
|
Happy to revert the full macos-15-intel test for the sake of time, but could leave in the reordering of steps to speed up the other CI runs. |
Contributor
|
Sorry, should have reviewed it properly before, you mention it is not possible to run docker on arm 🙈 |
Contributor
Author
|
Yeah its a real bummer TBH, but maybe that gets solved when all the runners are m4 or whatever...not holding my breath. |
Contributor
Author
|
huh wait, why is it breaking now? |
Contributor
Author
|
Ok seems like (atleast the ubuntu failure was a flaky one). |
paraseba
approved these changes
Feb 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an attempt to expand the full testing (not just unit tests) to macos runners.
Apparently it is very difficult (if not impossible?) to run docker within (already virtualized?) runners (see here).
My initial hope was to catch #1654 here before implementing a fix, but it seems like this is a behavior that was either changed after macos 15 or is somehow unique to my machine.
Either way I thought it could be good to test fully against at least one macos version?
The remaining question is if its worth carrying these tests as they are significantly slower (still working on that).
Positive side effect of this endeavour: With claudes help I was able to reorganize the order and start compiling the tests while the docker setup finishes in parallel, which saves ~2 min on each test:
Before
After