fix: Prevent NullPointerException in ModerationRequestController#3708
Closed
ADITYA-CODE-SOURCE wants to merge 1 commit intoeclipse-sw360:mainfrom
Closed
fix: Prevent NullPointerException in ModerationRequestController#3708ADITYA-CODE-SOURCE wants to merge 1 commit intoeclipse-sw360:mainfrom
ADITYA-CODE-SOURCE wants to merge 1 commit intoeclipse-sw360:mainfrom
Conversation
Changed stateOptions.get(0).equalsIgnoreCase(state) to "open".equalsIgnoreCase(state) to avoid NPE when state parameter is null. This is a standard Java idiom - by putting the constant string first, if state is null, it returns false instead of throwing NPE. Fixes eclipse-sw360#3705
ADITYA-CODE-SOURCE
requested review from
GMishx,
KoukiHama,
ag4ums and
arunazhakesan
as code owners
GMishx
added
needs code review
needs general test
Member
|
@ADITYA-CODE-SOURCE please fix the PR description! |
GMishx
requested changes
Feb 23, 2026
| } | ||
|
|
||
| boolean stateOpen = stateOptions.get(0).equalsIgnoreCase(state); | ||
| boolean stateOpen = "open".equalsIgnoreCase(state); |
Member
There was a problem hiding this comment.
stateOptions can never be null, stateOptions.get(0) can never be null as they are set in line 193-194
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed potential NullPointerException in ModerationRequestController.getModerationRequestsByState method.
Changes
Changed from:
To:
Why This Fix Works
This is a standard Java idiom to avoid NullPointerException - by putting the constant string first ("open".equalsIgnoreCase(state)), if state is null, it simply returns false instead of throwing an NPE.
Testing
Fixes #3705