Skip to content

fix: Prevent NullPointerException in ModerationRequestController #3708

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ADITYA-CODE-SOURCE wants to merge 1 commit into from
Closed

fix: Prevent NullPointerException in ModerationRequestController #3708

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .../org/eclipse/sw360/rest/resourceserver/moderationrequest/ModerationRequestController.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,7 +200,7 @@ public ResponseEntity<CollectionModel<ModerationRequest>> getModerationRequestsB
"Invalid ModerationRequest state '%s', possible values are: %s", state, stateOptions));
}

boolean stateOpen = stateOptions.get(0).equalsIgnoreCase(state);
boolean stateOpen = "open".equalsIgnoreCase(state);
Copy link
Member

@GMishx GMishx Feb 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

stateOptions can never be null, stateOptions.get(0) can never be null as they are set in line 193-194

Map<PaginationData, List<ModerationRequest>> modRequestsWithPageData =
sw360ModerationRequestService.getRequestsByState(sw360User, pageable, stateOpen, allDetails);
return getModerationResponseEntity(pageable, request, allDetails, modRequestsWithPageData);
Expand Down