Skip to content

Hide setting entry point to manage 3Pid if homeserver capability m.3pid_changes is set to false.#8618

Merged
bmarty merged 1 commit into
developfrom
feature/bma/3pidCapability
Aug 22, 2023
Merged

Hide setting entry point to manage 3Pid if homeserver capability m.3pid_changes is set to false.#8618
bmarty merged 1 commit into
developfrom
feature/bma/3pidCapability

Conversation

@bmarty
Copy link
Copy Markdown
Member

@bmarty bmarty commented Aug 21, 2023

Type of change

  • Feature
  • Bugfix
  • Technical
  • Other :

Content

See #8615.

The capability is already parsed and stored into DB, only the UI part was missing to complete #8615.

Motivation and context

Closes #8615.

Prevent access to 3pid modification which will fail.

Screenshots / GIFs

Tests

  • Connect to a server with capability to change 3pid set to false. I hacked the code to simulate this at this line.
  • Observe that the setting is hidden

Tested devices

  • Physical
  • Emulator
  • OS version(s):

Checklist

@bmarty bmarty requested a review from hughns August 21, 2023 15:29
@sonarqubecloud
Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

warning The version of Java (11.0.20) you have used to run this analysis is deprecated and we will stop accepting it soon. Please update to at least Java 17.
Read more here

@bmarty bmarty merged commit 87e5900 into develop Aug 22, 2023
@bmarty bmarty deleted the feature/bma/3pidCapability branch August 22, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

EA: Use 3PID capability to show / hide email UI in settings for MSC3824 OIDC-aware

2 participants