Skip to content

Hide setting entry point to manage 3Pid if homeserver capability m.3pid_changes is set to false. #8618

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bmarty merged 1 commit into from
Aug 22, 2023
Merged

Hide setting entry point to manage 3Pid if homeserver capability m.3pid_changes is set to false. #8618

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions changelog.d/8615.misc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Use 3PID capability to show / hide email UI in settings
7 changes: 7 additions & 0 deletions vector/src/main/java/im/vector/app/features/settings/VectorSettingsGeneralFragment.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,9 @@ class VectorSettingsGeneralFragment :
private val mPasswordPreference by lazy {
findPreference<VectorPreference>(VectorPreferences.SETTINGS_CHANGE_PASSWORD_PREFERENCE_KEY)!!
}
private val mManage3pidsPreference by lazy {
findPreference<VectorPreference>(VectorPreferences.SETTINGS_EMAILS_AND_PHONE_NUMBERS_PREFERENCE_KEY)!!
}
private val mIdentityServerPreference by lazy {
findPreference<VectorPreference>(VectorPreferences.SETTINGS_IDENTITY_SERVER_PREFERENCE_KEY)!!
}
Expand Down Expand Up @@ -197,6 +200,10 @@ class VectorSettingsGeneralFragment :
mPasswordPreference.isVisible = false
}

// Manage 3Pid
// Hide the preference if 3pids can not be updated
mManage3pidsPreference.isVisible = homeServerCapabilities.canChange3pid

val openDiscoveryScreenPreferenceClickListener = Preference.OnPreferenceClickListener {
(requireActivity() as VectorSettingsActivity).navigateTo(
DiscoverySettingsFragment::class.java,
Expand Down