exclude files in the tests directory from isEmberCoreModule#213
Open
nathancharles wants to merge 5 commits intoember-cli:masterfrom
Open
exclude files in the tests directory from isEmberCoreModule#213nathancharles wants to merge 5 commits intoember-cli:masterfrom
nathancharles wants to merge 5 commits intoember-cli:masterfrom
Conversation
rwjblue
reviewed
Jan 4, 2019
Member
rwjblue
left a comment
rwjblue
left a comment
There was a problem hiding this comment.
Thanks for working on this! I had one minor tweak suggestion, but otherwise looks good to me...
Remove duplicate definition of isEmberMixin - from bad merge resolution
alexlafroscia
added a commit
to alexlafroscia/eslint-plugin-ember
that referenced
this pull request
Nov 21, 2019
The original logic for determining if a Identifier was of a specific Ember class used the file name to make this decision, rather than resolving the import of the Identifier back to the Ember module it was imported from. This ended up causing a number of issues in lint rule in cases where people places a class in a location that was unexpected based on Ember’s convention. Such issues include ember-cli#601 and ember-cli#430. Making this change avoids the need for something like ember-cli#213, which adds additional logic based on file names to prevent some of these issues. Closes ember-cli#590
alexlafroscia
added a commit
to alexlafroscia/eslint-plugin-ember
that referenced
this pull request
Nov 21, 2019
The original logic for determining if a Identifier was of a specific Ember class used the file name to make this decision, rather than resolving the import of the Identifier back to the Ember module it was imported from. This ended up causing a number of issues in lint rule in cases where people places a class in a location that was unexpected based on Ember’s convention. Such issues include ember-cli#601 and ember-cli#430. Making this change avoids the need for something like ember-cli#213, which adds additional logic based on file names to prevent some of these issues. Closes ember-cli#590
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR resolves #212