fix(StdStorage): fix uint256 underflow infinite loop in find()#833
Merged
DaniPopes merged 1 commit intofoundry-rs:masterfrom Mar 15, 2026
Merged
Conversation
Co-Authored-By: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
DaniPopes
approved these changes
Mar 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reverse-iteration loop in
find()usesfor (uint256 i = reads.length; --i >= 0;)— sinceiis auint256,--i >= 0is always true. Wheniwraps past zero, the loop runs forever instead of terminating.For tokens whose
balanceOfreads multiple storage slots and returns a derived value (reflection tokens),checkSlotMutatesCallnever finds a matching slot, and the loop neverbreaks — causingdeal()to hang indefinitely.Fix:
for (uint256 i = reads.length; i > 0;) { --i; ... }Additionally, caps the number of storage slots checked to 256 to prevent excessive RPC calls on contracts with complex storage access patterns.
Adds a regression test with a mock reflection token and a fork test with BabyDoge on BSC.
Closes #740
Closes #409
Co-Authored-By: DaniPopes 57450786+DaniPopes@users.noreply.github.com
Prompted by: DaniPopes