fix(StdStorage): limit slot search to 256 reads#834
Closed
decofe wants to merge 1 commit intofoundry-rs:masterfrom
Closed
fix(StdStorage): limit slot search to 256 reads#834decofe wants to merge 1 commit intofoundry-rs:masterfrom
decofe wants to merge 1 commit intofoundry-rs:masterfrom
Conversation
Cap the number of storage slots checked in find() to 256 to prevent excessive RPC calls on contracts with complex storage access patterns (e.g. reflection tokens). Adds a fork regression test with BabyDoge on BSC. Closes foundry-rs#740 Co-Authored-By: DaniPopes <57450786+DaniPopes@users.noreply.github.com>
decofe
requested review from
0xrusowsky,
DaniPopes,
grandizzy,
klkvr,
mattsse,
onbjerg and
zerosnacks
as code owners
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #833. Caps the number of storage slots checked in
find()to 256 to prevent excessive RPC calls on contracts with complex storage access patterns (e.g. reflection tokens like BabyDoge).#833 fixed the uint256 underflow infinite loop, but the loop still iterates through all recorded storage reads. For reflection tokens on a fork,
balanceOfreads many slots, andcheckSlotMutatesCallmakes 2 calls per slot — each triggering dozens ofeth_getStorageAtRPCs. This results in 1000+ RPC requests before eventually reverting.Changes
MAX_SLOT_READS = 256constant — only check the last 256 recorded slots (most likely to contain the target)0xc748...e8de)Closes #740
Co-Authored-By: DaniPopes 57450786+DaniPopes@users.noreply.github.com
Prompted by: DaniPopes