Skip to content

v1.93.16.0 fix(review): Step 11.5 bind ignores untracked root dot-dir scratch (GST-985) - #3873

Merged
capy-ai[bot] merged 6 commits into
mainfrom
gst-985-review-bind-scratch
Nov 2, 2026
Merged

capy-ai[bot] merged 6 commits into
mainfrom
gst-985-review-bind-scratch

Conversation

@garrytan

@garrytan garrytan commented Nov 2, 2026 •

Copy link
Copy Markdown
Owner
{
  "schema_version": 1,
  "pr": 3873,
  "head": "a64f2dbd11798cab704e5de3246435b065658395",
  "version": "1.92.81.0",
  "base": "main",
  "gate": {
    "pregate": {
      "pass": 6703,
      "fail": 0,
      "skip": 0
    }
  },
  "session_kind": "unattended",
  "head_tree": "43408763dcb845f2d3c333c77658bcd7a8c13f44",
  "product_patch_id": "1859d57ecbcca59dddc6b680b9c0c0134ea3d95a",
  "gstack_version": "1.92.81.0",
  "review_depth": {
    "depth": "light",
    "class": "code",
    "runtime_lines": 35,
    "rules": "b2272efd321ce7cb",
    "base": "be38ff07c21365dc4b6de468081d4fd7456fe171",
    "registry": "be38ff07c21365dc4b6de468081d4fd7456fe171",
    "gate_scan": {
      "tagged": 0,
      "head": "a64f2dbd11798cab704e5de3246435b065658395"
    },
    "reasons": [
      "runtime=35"
    ],
    "risk": []
  },
  "pregate": "requires-remote cleared @43408763dcb8 (1 checks, current for a64f2dbd1179)",
  "requires_remote": [
    "free-tests.yml/macos-named-regressions: https://github.com/garrytan/gstack/actions/runs/41472443173/attempts/1",
    "windows-smoke.yml/windows-smoke: https://github.com/garrytan/gstack/actions/runs/41472443075/attempts/1",
    "pregate.json/remote_gate: remote-gate tree=43408763dcb8 tests=6703"
  ],
  "issues": {
    "fixes": [],
    "refs": [],
    "flakes": []
  },
  "docs": {
    "status": "updated",
    "scope": "docs/troubleshooting.md, docs/review-policy.md, docs/pregate.md and the changelog fragment against gstack-wtree --review"
  },
  "review_loop": {
    "passes": 1,
    "blocking_found": 2,
    "deferred": 0,
    "noted": 1,
    "fixed": 2,
    "scope": "frozen",
    "fix_checks": 1,
    "rounds": 2,
    "unrecorded": 2,
    "ledgers_read": 3,
    "dispatches": {
      "specialist": 3
    }
  },
  "review_loop_exception": {
    "accepted_by": "GStack Minder (GSTA-36)",
    "date": "2026-11-02",
    "via": "rule 23 grant, approval a-a8f467085104",
    "reason": "GSTA-36 2026-11-02: rule 23 grant, one scoped fix-check on the bin/gstack-wtree $REAL_INDEX and ..?* glob hunks; cap 15,000 credits | scoped fix-check (p3) found 1 INFORMATIONAL, noted: REAL_INDEX picked when -f but unreadable (mode 000 index) fails open for a tracked dot-dir; below the floor",
    "fix_check": {
      "head": "8f453e24028370f83b8059f851421d6a2c633dae",
      "findings": 1,
      "files": [
        "bin/gstack-wtree",
        "test/review-start-evidence.test.ts"
      ]
    }
  }
}

What changed

Review records (gstack-review-log, gstack-review-read) now fingerprint with gstack-wtree --review. It leaves out root dot-folders that hold no tracked file, such as a test lane's .review-units-test-*/ scratch. .github/ and .gstack/ always count, and so does any tracked file. Every other gstack-wtree caller (pregate, evidence, Step 16 route, ship-queue) keeps the whole tree.

Before: scratch that appeared or vanished mid-review moved the tree, Step 11.5 refused to bind, and the only repair was rerunning Steps 9 to 11.5 (about 20M tokens, GEVA-2 / gstack-evals #142). After: the bind holds, and a tracked edit or an untracked .github/ or .gstack/ file still breaks it.

Why

GST-985. The failing-first test (GST-985: an untracked scratch dir created|removed mid-review still binds) failed on main 1022f4f: Expected "verified", Received "changed".

Blast radius

Approvals

  • Option C with the .github/ and .gstack/ carve-out: GStack Minder (GSTA-36), 2026-11-02.
  • Rule 23 grant (a-a8f467085104): "GSTA-36 2026-11-02: rule 23 grant, one scoped fix-check on the bin/gstack-wtree $REAL_INDEX and ..?* glob hunks; cap 15,000 credits".

Pre-Landing Review

  • Pass 1 (specialists, red team, coverage) raised 3 INFORMATIONAL findings. Two were auto-fixed (8f453e2) and one is noted.
  • The round 2 fix-check was clean.
  • Step 11: the native voice raised 2 FIXABLE items, which were fixed under the grant (4884b65). The outside voice (gpt-6.1-sol) found nothing.
  • The scoped fix-check raised 1 INFORMATIONAL item, noted below.
  • Gate edits: none detected (2 listed, 0 read).

Review-loop exception: accepted by GStack Minder (GSTA-36) 2026-11-02 via rule 23 grant, approval a-a8f467085104: GSTA-36 2026-11-02: rule 23 grant, one scoped fix-check on the bin/gstack-wtree $REAL_INDEX and ..?* glob hunks; cap 15,000 credits | scoped fix-check (p3) found 1 INFORMATIONAL, noted: REAL_INDEX picked when -f but unreadable (mode 000 index) fails open for a tracked dot-dir; below the floor (fix-check at 8f453e2, 1 finding)

Review notes (open, accepted below the floor)

  • If .git/index exists but is unreadable (mode 000), the --review tracked-file check fails open for a tracked dot-dir. The Captain accepts this as below the floor, with no follow-up.
  • A PR that adds a brand-new root dot-folder and leaves it untracked through review gets a Step 16 behavior stop. This fails closed. Staging it with git add -N avoids the stop.
  • Untracked config dot-folders such as .claude/settings.local.json and .husky/ can change mid-review without unbinding it. Test evidence still uses the whole tree.
  • Standalone /review prose (review/SKILL.md.tmpl:97) still says the snapshot includes all untracked files.
  • Flaky: start receipt is single-use and scoped to the reviewer and branch (gstack-review-log stamps wtree unconditionally: a non-converged /ship review loop grades unreviewed code CURRENT in the land-and-deploy readiness gate #2803) hits Bun's 5 s timeout on 4-core machines. It also fails at main 1022f4f, so this diff doesn't cause it, and it's ledgered by GStack Minder.

Open in Capy

garrytan and others added 4 commits November 2, 2026 14:03
…eeps .github/ and .gstack/ (GST-985)

gstack-review-log and gstack-review-read fingerprint with gstack-wtree --review, which
leaves out root dot-directories that hold no tracked file. A test lane's
.review-units-test-* scratch appearing or vanishing mid-review no longer unbinds the
Step 9 row; .github/ and .gstack/ always count, and every other gstack-wtree caller
keeps the whole tree.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ot dirs)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@trunk-io

trunk-io Bot commented Nov 2, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

garrytan and others added 2 commits November 2, 2026 15:31
@github-actions github-actions Bot changed the title fix(review): Step 11.5 bind ignores untracked root dot-dir scratch (GST-985) v1.93.16.0 fix(review): Step 11.5 bind ignores untracked root dot-dir scratch (GST-985) Nov 2, 2026
@capy-ai
capy-ai Bot merged commit 9cc40e0 into main Nov 2, 2026
46 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant