Repository navigation
v1.93.16.0 fix(review): Step 11.5 bind ignores untracked root dot-dir scratch (GST-985) - #3873
Merged
Merged
Conversation
…eeps .github/ and .gstack/ (GST-985) gstack-review-log and gstack-review-read fingerprint with gstack-wtree --review, which leaves out root dot-directories that hold no tracked file. A test lane's .review-units-test-* scratch appearing or vanishing mid-review no longer unbinds the Step 9 row; .github/ and .gstack/ always count, and every other gstack-wtree caller keeps the whole tree. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ot dirs) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Review records (
gstack-review-log,gstack-review-read) now fingerprint withgstack-wtree --review. It leaves out root dot-folders that hold no tracked file, such as a test lane's.review-units-test-*/scratch..github/and.gstack/always count, and so does any tracked file. Every othergstack-wtreecaller (pregate, evidence, Step 16 route, ship-queue) keeps the whole tree.Before: scratch that appeared or vanished mid-review moved the tree, Step 11.5 refused to bind, and the only repair was rerunning Steps 9 to 11.5 (about 20M tokens, GEVA-2 / gstack-evals #142). After: the bind holds, and a tracked edit or an untracked
.github/or.gstack/file still breaks it.Why
GST-985. The failing-first test (
GST-985: an untracked scratch dir created|removed mid-review still binds) failed on main 1022f4f:Expected "verified", Received "changed".Blast radius
--review. Without the flag the output is byte-for-byte the same..github/and.gstack/, a..xdir, andgit add -Nunder the read-tree fallback.git ls-filesagainst the real index, which is read-only.Approvals
.github/and.gstack/carve-out: GStack Minder (GSTA-36), 2026-11-02.Pre-Landing Review
Review-loop exception: accepted by GStack Minder (GSTA-36) 2026-11-02 via rule 23 grant, approval a-a8f467085104: GSTA-36 2026-11-02: rule 23 grant, one scoped fix-check on the bin/gstack-wtree $REAL_INDEX and ..?* glob hunks; cap 15,000 credits | scoped fix-check (p3) found 1 INFORMATIONAL, noted: REAL_INDEX picked when -f but unreadable (mode 000 index) fails open for a tracked dot-dir; below the floor (fix-check at 8f453e2, 1 finding)
Review notes (open, accepted below the floor)
.git/indexexists but is unreadable (mode 000), the--reviewtracked-file check fails open for a tracked dot-dir. The Captain accepts this as below the floor, with no follow-up.git add -Navoids the stop..claude/settings.local.jsonand.husky/can change mid-review without unbinding it. Test evidence still uses the whole tree.start receipt is single-use and scoped to the reviewer and branch(gstack-review-log stamps wtree unconditionally: a non-converged /ship review loop grades unreviewed code CURRENT in the land-and-deploy readiness gate #2803) hits Bun's 5 s timeout on 4-core machines. It also fails at main 1022f4f, so this diff doesn't cause it, and it's ledgered by GStack Minder.