Skip to content

feat: design review lite in /review and /ship + gstack-diff-scope (v0.6.3) - #142

Merged
garrytan merged 4 commits into
mainfrom
garrytan/review-qa-design-check
Mar 18, 2026
Merged

garrytan merged 4 commits into
mainfrom
garrytan/review-qa-design-check

Conversation

@garrytan

Copy link
Copy Markdown
Owner

Summary

  • Every PR touching frontend code now gets a design review automatically in /review (Step 4.5) and /ship (Step 3.5)
  • 20-item code-level design checklist with HIGH/MEDIUM/LOW confidence tags — catches AI slop, typography issues, accessibility gaps, !important abuse
  • Mechanical CSS fixes (outline:none, !important, font-size < 16px) are auto-fixed; design judgment calls ask the user
  • New bin/gstack-diff-scope helper categorizes branch changes (SCOPE_FRONTEND, SCOPE_BACKEND, SCOPE_PROMPTS, SCOPE_TESTS, SCOPE_DOCS, SCOPE_CONFIG)
  • Review Readiness Dashboard distinguishes "LITE" (code-level) vs "FULL" (visual audit) design reviews
  • E2E eval with planted CSS/HTML fixtures verifying detection of 7 design anti-patterns

Test Coverage

Step 3.4: All new code paths have test coverage.

  • generateDesignReviewLite() → covered by gen-skill-docs + skill-validation tests
  • TOUCHFILES entry → covered by touchfiles.test.ts
  • E2E eval → planted fixture with 7 anti-patterns, threshold ≥ 4/7

Pre-Landing Review

No issues found.

Design Review

No frontend files changed — design review skipped.

Eval Results

No prompt-related files changed — evals skipped.

TODOS

  • "Smart review relevance detection" updated to PARTIALLY SHIPPED — gstack-diff-scope provides the infrastructure, dashboard conditional row display is remaining work

Test plan

  • bun run gen:skill-docs — all 15 templates resolve
  • bun test — all free tests pass (skill validation, gen-skill-docs, touchfiles)
  • bun run skill:check — all skills healthy
  • gstack-diff-scope main — correctly categorizes changes

🤖 Generated with Claude Code

garrytan and others added 4 commits March 17, 2026 17:55
bin/gstack-diff-scope categorizes branch changes into SCOPE_FRONTEND,
SCOPE_BACKEND, SCOPE_PROMPTS, SCOPE_TESTS, SCOPE_DOCS, SCOPE_CONFIG.

review/design-checklist.md is a 20-item code-level checklist with
HIGH/MEDIUM/LOW confidence tags for detecting design anti-patterns
from source code.
Add generateDesignReviewLite() resolver, insert {{DESIGN_REVIEW_LITE}}
partial in review Step 4.5 and ship Step 3.5. Update dashboard to
recognize design-review-lite entries. Ship pre-flight uses
gstack-diff-scope for smarter design review recommendations.
Planted CSS/HTML fixtures with 7 design anti-patterns. E2E test
verifies /review catches >= 4 of 7 (Papyrus font, 14px body text,
outline:none, !important, purple gradient, generic hero copy,
3-column feature grid).
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@garrytan
garrytan merged commit 28becb3 into main Mar 18, 2026
skylartaylor pushed a commit to skylartaylor/skystack that referenced this pull request Mar 18, 2026
….6.3) (garrytan#142)

* feat: gstack-diff-scope helper + design review checklist

bin/gstack-diff-scope categorizes branch changes into SCOPE_FRONTEND,
SCOPE_BACKEND, SCOPE_PROMPTS, SCOPE_TESTS, SCOPE_DOCS, SCOPE_CONFIG.

review/design-checklist.md is a 20-item code-level checklist with
HIGH/MEDIUM/LOW confidence tags for detecting design anti-patterns
from source code.

* feat: integrate design review lite into /review and /ship

Add generateDesignReviewLite() resolver, insert {{DESIGN_REVIEW_LITE}}
partial in review Step 4.5 and ship Step 3.5. Update dashboard to
recognize design-review-lite entries. Ship pre-flight uses
gstack-diff-scope for smarter design review recommendations.

* test: E2E eval for design review lite detection

Planted CSS/HTML fixtures with 7 design anti-patterns. E2E test
verifies /review catches >= 4 of 7 (Papyrus font, 14px body text,
outline:none, !important, purple gradient, generic hero copy,
3-column feature grid).

* chore: bump version and changelog (v0.6.3.0)

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

---------

Co-authored-by: Claude Opus 4.6 <noreply@anthropic.com>
capy-ai Bot added a commit that referenced this pull request Nov 2, 2026
…ion line and closed code fences (GST-983, GST-984) (#3884)

* fix(receipt): --check-prose skips the Documentation exception line and closed code fences (GST-983, GST-984)

write --docs with an owner exception requires the PR body to carry the Documentation exception line word for word, and read --check-prose read the owner reason in it as counter claims, the deadlock GST-977 fixed for the Review-loop exception line. Pasted test output and quoted code in fenced blocks were read as receipt counts too (gstack-evals #142). The prose check now skips the exact docs exception line and every closed code fence; a fence that never closes stays prose. Failing-first: the three new cases fail on main d45c350.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(receipt): inline triple backticks open no fence, and nothing after an unclosed fence is skipped (GST-984 review)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant