Repository navigation
v1.93.19.0 fix(receipt): --check-prose skips the Documentation exception line and closed code fences (GST-983, GST-984) - #3884
Merged
Conversation
…d closed code fences (GST-983, GST-984) write --docs with an owner exception requires the PR body to carry the Documentation exception line word for word, and read --check-prose read the owner reason in it as counter claims, the deadlock GST-977 fixed for the Review-loop exception line. Pasted test output and quoted code in fenced blocks were read as receipt counts too (gstack-evals #142). The prose check now skips the exact docs exception line and every closed code fence; a fence that never closes stays prose. Failing-first: the three new cases fail on main d45c350. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…r an unclosed fence is skipped (GST-984 review) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gstack-ship-receipt read --check-proseno longer reads two kinds of text as counter claims:Documentation exception: …line thatwrite --docsmakes a PR body carry is skipped, the same way GST-977 skips the Review-loop exception line. The same words inside a longer line, or a line for a different exception, are still checked.```npm test``` ranopens no fence. A fence that never closes stays prose, and so does the rest of the body, so an unclosed fence can't hide the claims after it.A marker line replaces each skipped fence, so the text on either side never joins into one claim.
Why
With an owner's docs exception,
write --docsrequires the exception line word for word, but the prose check read the owner's reason as counts (for example "sections 1 and 2 skip the audit" became a "2 skip" claim), so no body could pass both checks. On gstack-evals #142 (a different repository), fenced test output and a quoted code comment were read as receipt counts and refused.Blast radius
The change is in
lib/ship-receipt-prose.tsonly:withoutExceptionLinesand a newwithoutFences.withoutApprovalsBlocksand its shared fence opener are unchanged. Docs:docs/ship-policy.md,docs/troubleshooting.md(receipt-prose-mismatch) and a changelog.d fragment. There are no network calls, environment reads, workflow or install edits, or new dependencies.Failing-first proof
Pre-Landing Review
Round 1 ran the full panel on b02b4f3: a batched specialist, red-team, the targeted gate reader (rendered by hand, since the plan prints TARGETED classes=none), the Step 7 coverage audit, the native adversarial voice and an outside voice on openai/gpt-6.1-sol. Two voices reproduced a real hole: an inline triple-backtick line, or a shorter fence inside an unclosed one, hid a wrong count. That was fixed in one batch at 523de7d with two new test rows.
Round 2 ran one scoped fix-check instead of
REVIEW_PLAN pass=2 next=full dispatches=2. The parent's brief, R51 and crew rule 30a allow one scoped fix-check after a round-1 floor batch, under a raised cap. The fix-check found nothing at the floor, andgstack-review-plan --last fix-checkprintedNEXT: done.The targeted record says failed because its brief was rendered on b02b4f3's diff, and the review fix moved the patch id. It was not re-dispatched, since that would be a third round.
Gate edits: none tagged (GATE_SCAN tagged=0).
Open notes (below the floor, not fixed)
withoutApprovalsBlocksstill treats an inline-backtick line as a fence opener, so a rendered Approvals block after one is read as prose. That fails closed.Documentation
Status: current. No documentation edits were needed.
Scope: merge base d45c350 to head 523de7d on
gst-983-984-prose-exception-fences, plus staged, unstaged and untracked content (all empty). Changed files: changelog.d fragment, docs/ship-policy.md, docs/troubleshooting.md, lib/ship-receipt-prose.ts and test/ship-receipt-prose.test.ts. The audit also read docs/review-policy.md and ship/sections/pr-body.md.tmpl for cross-references.Documentation health:
Coverage debt: none. No new commands, flags or environment variables. No architecture diagrams to check for drift. No new doc files, so discoverability is unchanged. Banned terms: none.
Approvals
None needed: this is a fix to an already-diagnosed problem (fix-lane exemption).