Repository navigation
v1.94.0.0 ship: CI is the one full test run (CI carry, tree cache, /ship beside CI) - #3901
Merged
Merged
Conversation
…ested fixes no longer force a second review loop (GST-407, GST-384, GST-391) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-triggers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # ship/DRIVER.md # ship/DRIVER.md.tmpl
…ds; trim elsewhere Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
comparePath returns same only when every hunk sits where the base change puts it (patch-ids ignore positions) and treats a file-mode change as changed; the scoped-review packet says when a fence is truncated; --docs-result must be the posted audit's result; the --context-reviewed record goes beside the packet, outside the worktree. Negative controls for each. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
A test edit routes as tests= only when it adds lines with no gate tag; a removed or changed line or an unreadable test diff goes through the full loop. Diffs skip textconv. A hunkless patch (binary, empty, mode-only) is same when its patch-id matches. Without --reviewed-base test files route as before. finish's packet path and attempt's state directory have fallbacks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ew is release metadata (GBRA-251) gateEditedPaths reads removed lines only inside hunks; carry refuses when a path listing fails; docs freshness stops on a failed listing; attempt counts an unreadable state file. releasePaths includes stamp_files paths whose edit is a version swap under stamp_patterns. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…t state A test-only edit with no gate tag gets the scoped fix-check of its test hunks instead of a lanes-only rerun. Packet write failures print a STOP or RECEIPT_CARRY_REFUSED. attempt's allowance uses an exclusive create. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…t diff outside context paths The attempt STOP no longer echoes the audit child's fix text. A scoped-review carry now requires the product patch-id without the context paths to match at both heads. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ch; name-only test globs only in test dirs A scoped-review packet section over 200 lines sends that path to the full loop instead of a truncated packet. The docs-result path match is exact. test_*.py, *Test.java and similar count as test code only under a test directory. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…roubleshooting (docs-a-1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…like ship-release (run 41193336209) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…-triggers Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # bin/gstack-ship-receipt
… and repair when a pass's tree moved (GST-430) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…e receipt fails closed on a failed diff (GST-448) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… review; carry --dry-run writes no packet (GST-442) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…the --docs-requested fix; trims keep the cap (GST-442, GST-444) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… temp and diff refusals - A notes-only pass is recorded clean only when every finding is fixed, or noted or deferred below the blocking floor (never CRITICAL or blocking), by its logger-stamped action, and the findings account for the claimed issue and critical counts (GST-430). - The preflight scoped carry route commits and pushes the base-merge fix before writing the packet (GST-442). - patchId refuses by name on an unwritable TMPDIR; the tree receipt names why its diff failed (GST-448). - Step 16 stage 3 spells out --docs-requested with its --docs-result (GST-444). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ng reads UNVERIFIED (red-team, pass 1) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…n rule, stale patch-id dirs swept - deriveFromFindings stamps gate rows with the session kind before deriving status, so a findings file cannot dispose of a gate finding the unattended logger forces open (outside-voice#1). - reviewFreshness reads a claimed row's findings with isOpenByAction, the rule the notes-only rewrite uses; noted and deferred clear a finding only when it is marked blocking: false and is not CRITICAL. - patchId sweeps gstack-patch-id-* directories over an hour old that a killed carry left in TMPDIR. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ion; resolved gate, skipped and below-floor actions stay CURRENT - isOpenFinding treats action 'open' (the logger's forced-open stamp) as open before a row's status or disposition. - reviewFreshness flags a claimed clean row only for an 'open' action or a CRITICAL or blocking deferral or note, so interactive kept and restored gates, skipped advisories and INFORMATIONAL deferrals read CURRENT as before. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…the git dir; changelog matches the review-log floor Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… finding reads UNVERIFIED (pass 2 red-team) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…fusal (docs-d-1 audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…hip-workflow-clarity pin) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…timeout (60 s); pregate literals check Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…11 (rule 19 grant) Conflicts resolved keeping both sides: bin/gstack-review-plan (baseContainsHead and approval-record imports); scripts/harness-version.json (main's session-ledger and session-runner pins, the wave's skill-fixture pin); ship/DRIVER.md.tmpl (main's done-or-voices wording, regenerated DRIVER.md 12,278 B); test/review-packets-removed.test.ts (merged review-army.md, adversarial.md and review-depth.ts pinned under combined GST-508+GST-464+GST-967 and GST-508+R51+GST-911+GST-967 entries).
…508 placeholders The merged sectionTexts differ from main's by exactly the wave's GST-508 exclude-pathspec lines (merged minus main equals wave minus fc292e2); the 1,440-case plan grid still hashes to main's MAIN_PLANS. Checks: GStack Minder drive handoffs/GSTA-202/merge-6841-checks.md.
…/accept split (GSTA-258 A) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… not read a bin Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # .gstack/pregate.json # bin/gstack-review-dispatch # bin/gstack-ship-receipt # docs/pregate.md # docs/troubleshooting.md # lib/pregate/config.ts # lib/ship-policy.ts # ship/DRIVER.md # ship/DRIVER.md.tmpl # test/review-exclude.test.ts # test/review-packets-removed.test.ts # test/review-targeted.test.ts
…s, so a paid-only remainder is not a dead end Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…ated KEPT entry Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…eflight keeps pregate.json /ship pass 1 findings red-team#1 and specialist-batched#1 (GSTA-258 piece A). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> # Conflicts: # lib/pregate/checks/lanes.ts
… is opt-in (plan choice F1) The uncleared remote_gate obligation names the CI route first when the base declares remote_gate_runs. docs/pregate.md says how gstack clears it, including the pull_request merge-ref tree mismatch. GSTA-258 piece A. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
record-ci records the base policy that mapped the lane; the CI-first remote gate hint respects --no-ci-carry and reruns the whole pregate; changelog and docs say what the tool does. GSTA-258 piece A. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…sage line (ship docs audit) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan
added a commit
that referenced
this pull request
Nov 3, 2026
1.94.0.0 shipped as #3901 without the key, so the released-key test reds once main's CHANGELOG is in the tree. The slot stamp moves the tentative value through stamp_paths. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2 tasks done
capy-ai Bot
added a commit
that referenced
this pull request
Nov 3, 2026
…y records HEAD's version (GST-1026, GST-1030) (#3892) * fix(stamp): name branch lines by position; carry and finish accept a kept VERSION claim (GST-979, GST-980) BranchSide carries the positions of the branch-added lines and stampOnlyLine takes the removed line position, so a base line whose text duplicates a branch line keeps the old-version floor. At equal versions only the branch own lines may move. stampOnlyText and stampedFiles accept a kept claim for those lines, and the carry leaves a stamp file out of the product comparison when its only change since the reviewed head is a stamp on the branch own rows and the base did not touch it. Failing-first: all five new tests fail on main fc292e2. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (GST-980 carry reads the stamp file line by line at the branch's positions, and keeps its mode) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(changelog): GST-979/980 entry counts the seven tests Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: the receipt carry follows a stamp on the branch's own rows (GST-980) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs: keep docs/ship-policy.md at the reviewed text; its GST-980 sentence already states the carry rule Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * Revert "docs: keep docs/ship-policy.md at the reviewed text; its GST-980 sentence already states the carry rule" This reverts commit f926ccb. * fix(stamp): a declared placeholder restamped on the branch's own row is a stamp; the carry names HEAD's version (GST-1026, GST-1030) stamp_placeholders (default []) lets a repo declare literals such as TBD that its restamp replaces with the new version inside a stamp_patterns template. stampOnlyLine accepts that move only on a branch line named by position; finish's stampedFiles, the receipt carry and the tree receipt share it. The carried receipt's version is HEAD's, read the way write reads it. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix: pre-landing review fixes (carry keeps a write --version receipt's version without a version source; a placeholder fill composes with a stamp move; a bare {version} template and a blank placeholder take no placeholder) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * docs(changelog): GST-1026/1030 fragment names the review fixes Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship-receipt): carry masks only package.json version on a pin-bump PR (GST-1030, GBEV-3) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * refactor(ship-policy): stamp key validation moves to lib/ship-policy-stamps.ts for the module-size ratchet Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * fix(ship-policy): stamp_placeholders key names the next minor 1.95.0.0 1.94.0.0 shipped as #3901 without the key, so the released-key test reds once main's CHANGELOG is in the tree. The slot stamp moves the tentative value through stamp_paths. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * test(restamp-mentions): set the stamp file's exec bit through the index so the mode-change carry case holds on Windows Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> * unstamp: return VERSION, package.json, CHANGELOG and the digest to main f6d6215's values and restore the changelog fragment after #3892 left train 100 The tentative STAMP_PLACEHOLDERS_KEY_VERSION goes back to 1.95.0.0 for the next slot stamp to move. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com> --------- Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 9, 2026
Closed
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
gstack-pregate on a 4-core machine: before, the test tier waited on the Ubicloud VM; after, the green Free Tests run at the same tree clears it. (Image render failed in this sandbox; text version below.)
Before/after as text: gstack-pregate on a 4-core machine: before, the test tier waited on the Ubicloud VM; after, the green Free Tests run at the same tree clears it
Why
"CI is the one full test run" (R65, Garry: "make sure gstack minder gets this fixed in ship in gstack"). Every /ship ran the full free suite a second time on a VM or locally, about 10 minutes, after CI had already run it on the same tree. Now pregate and /ship reuse CI's verified run at the exact tree, and on gstack that is the default way the remote gate clears (plan choice F1, approved by Garry); the VM is an opt-in.
Blast radius
This changes what pregate and /ship accept as test evidence:
lib/pregate/index.ts(autoCarry,carryGate),lib/ci-carry.ts,bin/gstack-evidence record-ci,lib/ship-bin-common.tsandlib/ship-release.ts(finish,accept,push --early). What keeps it safe is that a carry needs a green same-repository run whosetree.jsonnames HEAD's exact clean tree and covers the inventory. A merge-refpull_requestrun on a branch behind main is refusedtree_mismatch, as seen live at 9125936 (script ran:~/.capy/work/gstack/ship-3901/pregate-head.out).Approvals
Source: gstack-approvals record for gsta-258-a-ci-carry (display only; not an approval citation).
Summary
Before, at 179b128, the remote gate run took 618 s. After, at 02b2f29, a full
gstack-pregatecarried Free Tests run 41567501815 (780 of 892 files) and clearedpregate.json/remote_gate(tests=34511 skipped=112) in 27 s.findCarryandgstack-ci-carry find|wait. The tests stage looks up the run by itself (--no-ci-carryturns it off). A /ship lane carries only when the base'sship_lanes_frommaps its exact command and the run covers its inventory.gstack-evidence record-cinow finds and verifies the run itself and records the base policy that mapped the lane. The receipt recordsci_carried.gstack-evidence run --reusereuses a pass at the same tree, command and runtime. A newer failure vetoes an older pass.push --earlyruns the secrets scan and sealed guard first.finishdefers a mapped lane it can't carry yet, and writes that preflight-only run to its own file.acceptcarries the lane from the green run at the final head..gstack/pregate.jsonalready declaresremote_gate_runson main, so no policy key changed.carryGateclears the gate from the carried run, and the uncleared obligation names the CI route first: push,gstack-ci-carry wait --base main, then rerungstack-pregate --allow-repo-commands. The local preflight stage and the sealed guard are unchanged.Gate code (R45, please read)
PREGATE_REMOTE_PAID_ONLY tests=0for them andclear --runrefusespaid_only, so nothing could clear the gate.carryGatenow clears it from the same run underclear --run's own checks. Failing-first test:test/pregate-carry-gate.test.ts("the carried run clears the gate when only skipped files remain…"). A second case shows a run missing an inventory file leaves the gate uncleared; a third shows the CI route is named first, and not under--no-ci-carry.lib/pregate/checks/lanes.tsobligation text,docs/pregate.md("Small machines and the remote gate", "gstack's own gate"), and the CREW.mdREMOTE_PREGATEreplacement text in the Captain's drive athandoffs/GSTA-258/A-captain-notes.md.record-citook run ids and test counts from its caller (pass 1 red-team);finishoverwrotepregate.jsonwith a preflight-only run (pass 1 testing).Security read
No new dependency, and no workflow, setup or install change. The network calls are GitHub Actions API reads through
gh(runs, jobs and thetested-treeartifact) that already existed forclear --run.ship_lanes_frominventory commands are pin-file commands: they run only with--allow-repo-commandsand are read only from the base branch.Test Coverage
New tests:
test/ci-carry.test.ts,test/evidence-reuse.test.ts,test/ship-ci-carry.test.tsandtest/pregate-carry-gate.test.ts. The coverage audit found thin coverage onaccept's refusal branches and onpush --early; no tests were generated for those.Tests ran: typecheck count unavailable
Tests ran: targeted 185
Pre-Landing Review
Pass 1 fixed two INFORMATIONAL findings (record-ci trusted caller-supplied run facts; finish overwrote pregate.json). Pass 2 noted one. Step 11's adversarial reader found three items it rated "Low, blocks: no"; the collector labeled them CRITICAL, so they were fixed in round 2 and checked by one granted fix-check, which noted one more. The outside voice found two defects in main's
lib/autoplan-lean.ts(#3897), deferred as issues.REVIEW_LOOP: passes=2 blocking_found=7 deferred=2 noted=2 fixed=4 scope=frozen unrecorded=3 ledgers_read=3 fix_checks=1 dispatches=6
Gate edits: none detected (6 listed, 0 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Outside review: completed (openai/gpt-6.1-sol, medium); request changes for the two main defects below, none in this PR's code.
Review-loop exception: accepted by GStack Minder 2026-11-03 via standing grant, GSTA-258 builds, 2026-11-03: one scoped fix-check after the round-2 cap, scoped to the three round-2 fixes in a102205 (fix-check at a102205, 1 finding)
Deferred findings
Blocking findings in code this PR did not change (review scope: frozen); filed as issues and not closed by this PR.
lib/autoplan-lean.ts:83Untracked .envrc / .env-production files are not excluded (only .env and .env.*) and can be inlined into the lean reviewer prompt.lib/autoplan-lean.ts:66origin/HEAD pointing at the feature branch makes the merge base HEAD, so the committed draft is omitted from the reviewer diff.Review notes
Below the blocking floor (advisory, informational, test-gap or wording items); recorded here and not fixed in this PR.
lib/pregate/checks/lanes.ts:536The new default remote-gate route tells the agent to 'rerun --stage tests' (lanes.ts obligation detail, and docs/pregate.md 'gstack's own gate':gstack-pregate --stage tests --allow-repo-commands). runPregate selects only that stage's checks and writes them over the default .gstack/tmp/pregate.json. The full record's preflight results (regen, secrets, strays, literals, timing, guards) are replaced by a record holding onlylanes. verifyPregate never checks that the preflight checks are present, sogstack-pregate verify,gstack-ship-queue ready(local-file path) and the ship receipt's pregateFieldFor all accept the tests-only record as a current pass. If the earlier full run had a preflight fail, such as stale generated output or a secrets hit, following the hint erases it from the record the gates read. Free Tests CI runs no gitleaks scan, so nothing else re-checks secrets at that tree. The docs say the preflight stage 'always run[s] here', but the evidence the gates consume no longer shows it. The ship-queue mirror guard checks only that tests-stage checks are present, not preflight ones.bin/gstack-evidence:695(fix-check) The newpolicyfield is audit-only:carriedand the receipt'sci_carrieddon't show or check which base policy mapped the lane.Issues
Refs #3914
Refs #3915
Documentation
Status: updated: three factual doc fixes for the CI-carry change, no blockers.
Scope: base
6f1dfd5bto heada102205e(27 committed files, nothing staged, unstaged or untracked). I searched all tracked doc and template files forgstack-ci-carry,ship_lanes_from,--no-ci-carry,record-ci,gstack-ship-release push --early/acceptand the--stage tests --remoteroute.Documentation coverage:
Common gaps:
ci_carriedandgstack-ship-release accepthave only reference coverage (docs/pregate.md#ci-carry and ship/sections/tests.md), with no how-to.docs/PROJECT_STRUCTURE.md's bin list does not namegstack-ci-carry; it ends with "etc.". No critical gaps. Diagram drift: none.Test plan
bun run typecheckandbun run typecheck:test(814 known diagnostics, none new)gstack-pregateat 02b2f29 carried CI and cleared the remote gateNot in this PR
Review depth (build C) and the pregate flaky exception (build B). Trial merges at a102205: with B (c935355), one conflict in
lib/pregate/index.tsimport lines, keep both. With C (de04a78), the conflicts are all C-against-main hunks (C conflicts with main alone in 16 files); this PR'sciCarriedhunk inbin/gstack-ship-receiptis not in any conflict.