Repository navigation
v1.94.18.0 test(qa): accept Windows' ENOENT in report-dir's non-directory case - #3936
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
test/qa-report-dir.test.ts: the "names the filesystem cause when .gstack is not a directory" case now acceptsENOTDIRorENOENTon Windows, and still requiresENOTDIRon every other platform.Why
Plan D (#3904) makes Windows-safe tests block the pull requests that touch them, so the curated subset has to be green. Windows Free Tests on main at f6d6215 (run 41607809007) failed three files, each twice (once in its shard and again in the serial flaky retry), so all three failures are deterministic:
test/qa-report-dir.test.ts: Windows reportsreport-dir failed: ENOENTwhere Unix reportsENOTDIR(shard 3: "Expected to contain: report-dir failed: ENOTDIR … Received … ENOENT"). The product names the real cause on both platforms; only the test assumed the POSIX code. Fixed here.test/restamp-mentions.test.ts(GST-980, the 100755 mode case): left alone; GSTA-234 fixes it in v1.94.16.0 fix(stamp): declared placeholder restamps are stamps; carry records HEAD's version (GST-1026, GST-1030) #3892.test/ship-ci-carry.test.ts(all six v1.94.0.0 ship: CI is the one full test run (CI carry, tree cache, /ship beside CI) #3901 CI-carry cases, including the pregate tests-stage case): left alone; v1.94.17.0 ci-carry: guard carry, jobs-mapped lanes, aliases, per-file carry of runner-skipped files, path-skipped jobs (GST-1186, GST-1189, GST-1190) #3929 excludes the whole file inscripts/lib/windows-curation.ts.The latest nightly, run 41420490350 at 39e0148, failed only
test/review-risk-linear.test.ts, which #3904 fixed.Summary
A Windows-only test failure would have blocked every pull request that touched report-dir once plan D landed. The test now checks for the error code each platform actually reports for the same mistake, so it keeps checking that the cause gets named without failing on Windows.
Blast radius
One assertion in one test file. No product code changes. On Linux and macOS the assertion is the same as before, so its coverage there doesn't change (focused run: 7 pass).
Test Coverage
Tests ran: focused 21
Pre-Landing Review
Pre-Landing Review: No issues found.
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=0 fixed=0 scope=frozen (light depth: tests class, runtime 0, so the printed plan dispatched no readers)
Gate edits: 1 listed, 1 read, 0 findings — the assertion is narrowed per platform; it still fails if the cause is missing.
Documentation
Status: current. No documentation changes were needed.
Scope: the committed diff f6d6215..e18241c on
gsta258-l3-windows-subset-reds(one assertion intest/qa-report-dir.test.tsplus the fragmentchangelog.d/gsta258-l3-windows-subset-reds.md), with no staged, unstaged or untracked files. Docs were searched for references to the changed test and error text, and the Windows CI claims were checked againstdocs/support-tiers.mdanddocs/TESTING_INTERNALS.md.Documentation health
docs/support-tiers.md: current (matches the fragment's Windows path-scoped check claims)docs/TESTING_INTERNALS.md: currentchangelog.d/gsta258-l3-windows-subset-reds.md: current (reviewed, not edited)Coverage debt: none. Diagram drift: none.
Test plan
bun test test/qa-report-dir.test.ts test/changelog-fragments.test.ts: 21 tests, exit 0