Skip to content

v1.94.18.0 test(qa): accept Windows' ENOENT in report-dir's non-directory case - #3936

Merged
capy-ai[bot] merged 2 commits into
mainfrom
gsta258-l3-windows-subset-reds
Nov 3, 2026
Merged

capy-ai[bot] merged 2 commits into
mainfrom
gsta258-l3-windows-subset-reds

Conversation

@garrytan

@garrytan garrytan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner
{
  "schema_version": 1,
  "pr": 3936,
  "head": "e18241cb38f21d4bf7e06c44ecd2947f832ee7a8",
  "version": "1.94.10.0",
  "base": "main",
  "gate": {
    "focused": {
      "pass": 21,
      "fail": 0,
      "skip": 0
    }
  },
  "session_kind": "unattended",
  "head_tree": "4e1793f304d6f88a2e0c18d554884a0203def5a6",
  "product_patch_id": "none",
  "gstack_version": "1.94.4.0",
  "review_depth": {
    "depth": "light",
    "class": "tests",
    "runtime_lines": 0,
    "rules": "18dcd562316f56ed",
    "base": "f6d6215f4e3aa155e3843d56123c9f262f523b5e",
    "registry": "f6d6215f4e3aa155e3843d56123c9f262f523b5e",
    "gate_scan": {
      "tagged": 0,
      "head": "e18241cb38f21d4bf7e06c44ecd2947f832ee7a8"
    },
    "reasons": [
      "runtime=0"
    ],
    "risk": []
  },
  "pregate": "pass @4e1793f304d6 (7 checks, current for e18241cb38f2)",
  "issues": {
    "fixes": [],
    "refs": [],
    "flakes": []
  },
  "docs": {
    "status": "current",
    "scope": "docs/, README.md, AGENTS.md, CONTRIBUTING.md (135 docs) against f6d6215..e18241c"
  },
  "review_loop": {
    "passes": 1,
    "blocking_found": 0,
    "deferred": 0,
    "noted": 0,
    "fixed": 0,
    "scope": "frozen",
    "rounds": 1
  }
}

What changed

  • test/qa-report-dir.test.ts: the "names the filesystem cause when .gstack is not a directory" case now accepts ENOTDIR or ENOENT on Windows, and still requires ENOTDIR on every other platform.

Why

Plan D (#3904) makes Windows-safe tests block the pull requests that touch them, so the curated subset has to be green. Windows Free Tests on main at f6d6215 (run 41607809007) failed three files, each twice (once in its shard and again in the serial flaky retry), so all three failures are deterministic:

The latest nightly, run 41420490350 at 39e0148, failed only test/review-risk-linear.test.ts, which #3904 fixed.

Summary

A Windows-only test failure would have blocked every pull request that touched report-dir once plan D landed. The test now checks for the error code each platform actually reports for the same mistake, so it keeps checking that the cause gets named without failing on Windows.

Blast radius

One assertion in one test file. No product code changes. On Linux and macOS the assertion is the same as before, so its coverage there doesn't change (focused run: 7 pass).

Test Coverage

Tests ran: focused 21

Pre-Landing Review

Pre-Landing Review: No issues found.
REVIEW_LOOP: passes=1 blocking_found=0 deferred=0 noted=0 fixed=0 scope=frozen (light depth: tests class, runtime 0, so the printed plan dispatched no readers)
Gate edits: 1 listed, 1 read, 0 findings — the assertion is narrowed per platform; it still fails if the cause is missing.

Documentation

Status: current. No documentation changes were needed.

Scope: the committed diff f6d6215..e18241c on gsta258-l3-windows-subset-reds (one assertion in test/qa-report-dir.test.ts plus the fragment changelog.d/gsta258-l3-windows-subset-reds.md), with no staged, unstaged or untracked files. Docs were searched for references to the changed test and error text, and the Windows CI claims were checked against docs/support-tiers.md and docs/TESTING_INTERNALS.md.

Documentation health

  • docs/support-tiers.md: current (matches the fragment's Windows path-scoped check claims)
  • docs/TESTING_INTERNALS.md: current
  • changelog.d/gsta258-l3-windows-subset-reds.md: current (reviewed, not edited)

Coverage debt: none. Diagram drift: none.

Test plan

  • bun test test/qa-report-dir.test.ts test/changelog-fragments.test.ts: 21 tests, exit 0
  • Free Tests run 41610142709 at e18241c: success (CI carry, 34688 tests)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@trunk-io

trunk-io Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

@github-actions github-actions Bot changed the title test(qa): accept Windows' ENOENT in report-dir's non-directory case v1.94.18.0 test(qa): accept Windows' ENOENT in report-dir's non-directory case Nov 3, 2026
@capy-ai
capy-ai Bot merged commit 44471cf into main Nov 3, 2026
49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant