Skip to content

v1.94.17.0 ci-carry: guard carry, jobs-mapped lanes, aliases, per-file carry of runner-skipped files, path-skipped jobs (GST-1186, GST-1189, GST-1190) - #3929

Merged
capy-ai[bot] merged 18 commits into
mainfrom
gsta258-l6-guard-carry
Nov 3, 2026
Merged

capy-ai[bot] merged 18 commits into
mainfrom
gsta258-l6-guard-carry

Conversation

@garrytan

@garrytan garrytan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner
{
  "schema_version": 1,
  "pr": 3929,
  "head": "5024bbb04be309af514c103ec09df7079d6913bc",
  "version": "1.94.10.0",
  "base": "main",
  "gate": {
    "free": {
      "pass": 34727,
      "fail": 0
    }
  },
  "ci_carried": [
    {
      "lane": "free",
      "run": 41609778840,
      "attempt": 1,
      "tree": "1c2efd84fe6999a2d2d32bf0fb3012465d9990ca"
    }
  ],
  "session_kind": "unattended",
  "head_tree": "1c2efd84fe6999a2d2d32bf0fb3012465d9990ca",
  "product_patch_id": "a392998605993a32fbf0db14e28c19294cbc1074",
  "gstack_version": "1.94.0.0",
  "review_depth": {
    "depth": "full",
    "class": "gate",
    "runtime_lines": 724,
    "rules": "b2272efd321ce7cb",
    "base": "f6d6215f4e3aa155e3843d56123c9f262f523b5e",
    "registry": "f6d6215f4e3aa155e3843d56123c9f262f523b5e",
    "gate_scan": {
      "tagged": 0,
      "head": "5024bbb04be309af514c103ec09df7079d6913bc"
    },
    "reasons": [
      "gate-class",
      "risk:security",
      "runtime=724"
    ],
    "risk": [
      "security"
    ]
  },
  "pregate": "requires-remote cleared @1c2efd84fe69 (7 checks, current for 5024bbb04be3)",
  "requires_remote": [
    "free-tests.yml/cso-macos-launcher: https://github.com/garrytan/gstack/actions/runs/41609778840/attempts/1",
    "free-tests.yml/macos-named-regressions: https://github.com/garrytan/gstack/actions/runs/41609778840/attempts/1",
    "windows-smoke.yml/windows-smoke: https://github.com/garrytan/gstack/actions/runs/41609778927/attempts/1",
    "pregate.json/remote_gate: remote-gate tree=1c2efd84fe69 tests=34727 skipped=113 runs=41609778840/1 profiles=ci-reuse/free-tests heads=5024bbb04be3 verified=2026-11-03T09:23:29.348Z"
  ],
  "issues": {
    "fixes": [],
    "refs": [
      3923,
      3929
    ],
    "flakes": []
  },
  "docs": {
    "status": "blocked",
    "scope": "docs inputs changed by the f6d6215f4 base merge (bin/gstack-ship-receipt, docs/pregate.md, lib/pregate/index.ts, lib/pregate/run-check.ts, lib/run-evidence.ts) after audit l6cdocs2 covered a8d2fee38",
    "exception": {
      "accepted_by": "GSTA-258",
      "date": "2026-11-03",
      "via": "GSTA-258 message to L6 (docs named risk, #3929 base merge)",
      "reason": "the f6d6215f4 base merge changed docs inputs (main's #3911 edits and the both-sides resolution); #3929's own docs are unchanged since l6cdocs2"
    }
  },
  "review_loop": {
    "passes": 2,
    "blocking_found": 8,
    "deferred": 0,
    "noted": 6,
    "fixed": 12,
    "scope": "frozen",
    "fix_checks": 3,
    "rounds": 5,
    "unrecorded": 3,
    "ledgers_read": 3,
    "dispatches": {
      "specialist": 2,
      "red-team": 2
    }
  },
  "review_loop_exception": {
    "accepted_by": "GStack Minder",
    "date": "2026-11-03",
    "via": "GSTA-258 (grant a-53beaec71a54)",
    "reason": "scoped reader on the windows-curation exclusion for test/ship-ci-carry.test.ts (windows-scoped-shard run 41607840098)",
    "fix_check": {
      "head": "5024bbb04be309af514c103ec09df7079d6913bc",
      "findings": 0
    }
  }
}

Why

Pull requests kept rerunning work CI had already done, or carrying lanes CI never really ran. Guard-only repos like founderstar reran about six minutes of suites per /ship. Lanes with no test files, like gbrain's verify and typecheck (run 41564913688), could not carry at all. alphaclaw's 46-test lane recorded the run's 9677. harness-evals' 75 runner-skipped tests counted as passed. truther's path-filtered jobs could not be carried safely. This PR makes CI carry cover those cases and fail closed everywhere else.

Summary

  • Guard carry (GST-1186). A pregate guard whose exact command the base's ship_lanes_from maps is carried from the verified CI run at this tree, through the same gstack-evidence record-ci path /ship lanes use. A local pass of the same command at the same tree is reused. CI rows never count through the ledger, because a CI pass counts only through record-ci's live check.
  • Jobs-mapped lanes (GST-1189). A ship_lanes_from entry can name the CI jobs that run a lane ("jobs": ["verify", "typecheck"]) instead of an inventory. It carries only when every named job succeeded in the newest attempt at HEAD's tree, and reports tests_ran=n/a.
  • GST-1190.
    • aliases declare other exact spellings of a lane.
    • A narrow lane reports its covered file count, never the run total.
    • --policy-from head --simulate proves a new map without writing or clearing anything. It needs --allow-repo-commands to run a branch inventory.
    • tree.json skipped_files are treated as uncovered. A lane whose entry declares per_file carries the covered files and runs only the skipped ones here. Without per_file the lane refuses as inventory_skipped and runs whole.
    • skippable lets a path-skipped job count only in a pull_request run whose gate job succeeded and whose gate inputs are unchanged from base.
  • Step 17 prose moved from v1.94.27.0 feat(pregate): housekeeping guards before every push (GST-1138) #3923, as GSTA-258 decided: /ship names the push guards in Step 17 and the early push.

How the rollout is split. This PR ships the reader inert for gstack itself. gstack's own .gstack/pregate.json declares none of the new keys, and gstack's own Free Tests writer (scripts/ci-tree-reuse.ts, a gstack-internal producer) does not emit skipped_files yet. So until the adoption PR lands, gstack's own lane behaves exactly as it does today. The skipped-files warning (N inventory file(s) skipped every test in CI) needs skipped_files in tree.json, so it starts printing for gstack with the adoption PR's writer, not with this one. A follow-up adoption PR turns on the writer, declares per_file for gstack's bun run test lane and raises min_gstack_version together. It waits until the pull requests now queued on older gstack (#3911, #3920, #3926, #3917) have landed, because an older gstack rejects a new key in main's policy.

Blast radius

Repos that map lanes or guards in ship_lanes_from. Carry now also refuses for a skipped inventory file, a gate input that changed, a non-pull_request skip, or a zero-test remainder. Each refusal makes the lane run locally, never pass. Security notes (R45): record-ci can now run the base policy's per_file command locally. The skippable check reads workflow and script blobs from git. --simulate runs a branch's inventory command only with --allow-repo-commands. Nothing reads secrets or widens permissions.

Test Coverage

  • test/ship-ci-carry.test.ts (+451 lines): guard carry in the founderstar shape (guards only, no lanes); jobs-mapped lanes (all jobs green carries; a missing, skipped or failed job refuses); aliases; narrow file counts; --simulate writes and clears nothing and runs a branch inventory only with --allow-repo-commands; skipped_files with and without per_file (a failing or zero-test remainder carries nothing; run_changed after the remainder); skippable gate inputs through ${{ github.workspace }}, working-directory and package scripts; passed never counts a CI row.
  • test/ci-carry.test.ts, test/evidence-reuse.test.ts, test/run-evidence.test.ts, test/helpers/fake-gh-runs.ts: the reader's new fields and refusal codes.
  • a working-tree edit during the post-remainder run recheck carries nothing (0f6ad9d): before the fix, record-ci exited 0 and wrote the CI row; after it, CARRY_NONE: tree_changed.
  • Failing first: every new review-fix and per-file test failed on the tree before its fix (log kept with the lane's trail).

Pre-Landing Review

REVIEW_LOOP: passes=2 blocking_found=8 deferred=0 noted=6 fixed=12 scope=frozen unrecorded=3 ledgers_read=3 fix_checks=3 dispatches=4

Full depth (gate class). Round 1 found three CRITICAL findings and one Medium (missed gate inputs, --simulate running a branch inventory without consent, passed counting CI rows, push-event skips); all were fixed. Round 2 found two CRITICAL findings (a zero-test remainder carried, a run could move to a new attempt during the remainder); both were fixed. A scoped fix-check (grant a-21d3128888cd) found one more CRITICAL: record-ci checked the working-tree fingerprint before its post-remainder runChanged() calls, so an edit made during them still carried. A second scoped fix-check (grant a-860fbd99026c) covered its fix in 0f6ad9d, which moves the check after those calls, and found nothing at the floor. After the base merge, one scoped reader (grant a-53beaec71a54) read the windows-curation entry at 5024bbb and found nothing.

Base merge (rule 19, GStack Minder's grant at f6d6215). b01ed69 merges main. #3911 conflicted in lib/pregate/index.ts and lib/pregate/run-check.ts, and both sides are kept: RunCheck has both unchanged? and failures?, ClearDecision takes main's exception, and buildRunCheck passes both failures: ghArtifactDeps(repo) and unchanged. 5024bbb then excludes test/ship-ci-carry.test.ts from the Windows-safe list, like its ship-bin-fixture siblings, because #3904's path-scoped Windows check ran it and every case fails at its first spawn there (windows-scoped-shard, run 41607840098).

Review-loop exception: accepted by GStack Minder 2026-11-03 via GSTA-258 (grant a-53beaec71a54): scoped reader on the windows-curation exclusion for test/ship-ci-carry.test.ts (windows-scoped-shard run 41607840098) (fix-check at 5024bbb, 0 findings)

Open notes (not fixed in this PR):

Issues

Closes GST-1186, GST-1189 and GST-1190 (Capy issues).

Refs #3923
Refs #3929

Documentation

Scope: docs inputs changed by the f6d6215 base merge (bin/gstack-ship-receipt, docs/pregate.md, lib/pregate/index.ts, lib/pregate/run-check.ts, lib/run-evidence.ts) and the record-ci recheck order at 0f6ad9d, after audit l6cdocs2 covered a8d2fee (docs/pregate.md, docs/troubleshooting.md, ship/SKILL.md.tmpl Step 17, ship/sections/tests.md.tmpl, CONTRIBUTING.md, ship/DRIVER.md.tmpl, docs/ship-policy.md, docs/standalone-binaries.md).

Result: blocked. Audit l6cdocs2 updated docs/pregate.md (#ci-carry, #ship-lanes-jobs, #ship-lanes-aliases, #prove-a-mapping, #skipped-files, #skippable, #guard-carry) and docs/troubleshooting.md (#pregate-gstack-too-old) at a8d2fee, with no blockers. The later fix at 0f6ad9d moves one record-ci refusal check that no doc describes (accepted by GSTA-258 as a named risk), and the base merge then changed docs inputs; the audit budget was used.

Documentation exception: accepted by GSTA-258 2026-11-03 via GSTA-258 message to L6 (docs named risk, #3929 base merge): the f6d6215 base merge changed docs inputs (main's #3911 edits and the both-sides resolution); #3929's own docs are unchanged since l6cdocs2

Debt: no how-to yet for adopting jobs, skippable and per_file (suggest /document-generate); docs/standalone-binaries.md and ship/sections/tests.md do not mention gstack-evidence passed/carried or the narrow tests_ran (files) count.

Test plan

  • CI Free Tests green at 5024bbb (run 41609778840), carried: LANE: free carried run=41609778840/1 tests_ran=34727; every check green there, windows-scoped-shard included
  • gstack-pregate verify ok on the stamped tree; remote gate cleared from run 41609778840 (skipped=113); macOS lanes from run 41609778840, Windows smoke from run 41609778927
  • Merge resolution: ship-ci-carry, ci-carry, run-evidence, evidence-reuse and pregate-flaky-exception tests all green; windows-curation readers all green
  • Focused tests: test/ship-ci-carry.test.ts, test/ci-carry.test.ts, test/evidence-reuse.test.ts, test/run-evidence.test.ts, test/ship-workflow-clarity.test.ts, test/parity-suite.test.ts, all green; bun run typecheck and typecheck:test clean

gstack: ok 1.94.0.0 for=ship

garrytan and others added 10 commits November 3, 2026 05:55
…CI or the ledger (GST-1186)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ulate proof, policy-base check on carried (GST-1189, GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…tree.json records skipped_files (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… find --policy-from head --simulate (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…rom #3923 per GSTA-258)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…(gate inputs, passed ignores CI rows, simulate consent, pull_request-only skips, guard not-owed)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…nnot print

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…h per_file

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ns must still stand (l6c-p2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…'s count must come from this run's row (l6c-p2 red-team)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@trunk-io

trunk-io Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

…check ratchet

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan and others added 3 commits November 3, 2026 07:38
…r_file move to the adoption PR; Step 17 keeps its refs/heads marker

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…oubleshooting (docs audit l6cdocs2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai
capy-ai Bot marked this pull request as ready for review November 3, 2026 08:11
…mainder run recheck (#3929 second fix-check)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan and others added 2 commits November 3, 2026 09:02
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

# Conflicts:
#	lib/pregate/index.ts
#	lib/pregate/run-check.ts
…n-fixture siblings (the path-scoped Windows check runs it at its first spawn)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@github-actions github-actions Bot changed the title ci-carry: guard carry, jobs-mapped lanes, aliases, per-file carry of runner-skipped files, path-skipped jobs (GST-1186, GST-1189, GST-1190) v1.94.17.0 ci-carry: guard carry, jobs-mapped lanes, aliases, per-file carry of runner-skipped files, path-skipped jobs (GST-1186, GST-1189, GST-1190) Nov 3, 2026
@capy-ai
capy-ai Bot merged commit d2e6318 into main Nov 3, 2026
50 checks passed
garrytan added a commit that referenced this pull request Nov 3, 2026
lib/run-evidence.ts keeps #3929's skipped_files, job_skipped, skipped and
skipped_jobs evidence and its verifyRun unchanged option next to #3930's
sizing_experiment field and refusal and the ignoreRun option.
docs/pregate.md run_profiles row keeps #3930's wording and adds skippable?.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan added a commit that referenced this pull request Nov 3, 2026
…GSTA-258 L4)

The rule 19 merge of main 1ccab0d put #3929's push-guards wording (61,418 on
main) together with J1's head=<sha> in the GSTACK_RESULT line, measuring 61,429.
Three rewordings beside that line bring the skeleton back to 61,418; the branch
ledger entry drops by 11 and the ship goldens are regenerated.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
capy-ai Bot added a commit that referenced this pull request Nov 3, 2026
…ry warning and record-ci recheck order (GSTA-258 L6 follow-up) (#3934)

* feat(pregate): a guard that already passed at this tree carries from CI or the ledger (GST-1186)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* feat(ci-carry): jobs-mapped lanes, aliases, narrow-lane counts, --simulate proof, policy-base check on carried (GST-1189, GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(ci-carry): a file whose every test skipped on CI is not carried; tree.json records skipped_files (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* feat(ci-carry): path-skipped jobs count only under an unchanged gate; find --policy-from head --simulate (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ship: name the pre-push guards in Step 17 and the early push (moved from #3923 per GSTA-258)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ci-carry: per-file lane carry for runner-skipped files; review fixes (gate inputs, passed ignores CI rows, simulate consent, pull_request-only skips, guard not-owed)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ship: Step 17 names the pre-push guards without a code this branch cannot print

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* pregate: gstack's bun run test lane runs its runner-skipped files with per_file

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ci-carry: a per_file remainder must run tests here and the carried runs must still stand (l6c-p2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ci-carry: read record-ci from its own last record line; the remainder's count must come from this run's row (l6c-p2 red-team)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test(ci-tree-reuse): type the skipped_files fixture for the test typecheck ratchet

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* Revert "pregate: gstack's bun run test lane runs its runner-skipped files with per_file"

This reverts commit fafbae5.

* ci-carry: ship the skipped_files reader inert; gstack's writer and per_file move to the adoption PR; Step 17 keeps its refs/heads marker

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs: guard carry, per_file and the too-old message in pregate and troubleshooting (docs audit l6cdocs2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* gstack-evidence record-ci: recheck the working tree after the post-remainder run recheck (#3929 second fix-check)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* gstack-evidence: sum bun --shard processes in a lane's tests_ran; docs: dispatch-carry warning and record-ci recheck order (GBEV-3, GSTA-258 L6 follow-up)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* gstack-evidence: keep shard and count lines that leave the output tail; sum only shards 1..N in order; soften the dispatch-carry mechanism claim (l6f-p1 fixes)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ci-carry: a pull_request run whose base moved names the one-command dispatch fix (TRUT-7)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs: the tree_mismatch refusal names its fix command (l6fdocs3)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ci-carry: a pull_request run that recorded its merge tree names the base-moved fix (the real tree_mismatch path; #3934 fix-check)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
capy-ai Bot added a commit that referenced this pull request Nov 3, 2026
…eck, lighter READY, head= on the result line (GSTA-258 L4) (#3926)

* fix(ship): receipt counts bind by finding id, every run kept, scoped re-check after a refused carry, READY tail, head= on the result line (GSTA-258 L4; GST-1136, GST-1168, GST-1179)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix(ship): goldens, head= in the base-red line test, Severity field after a closing quote (ggstack#71); repin ship/sections/review-army.md under GST-508+GST-464+GST-967+GSTA-258-L4 (brief-identity no-loss check: every cut brief unchanged)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix: pre-landing review fixes (J1 never re-checks a legacy receipt, a cut path walk or moved base context; legacy READY asks for the cross-family read)

Review-Finding: p1/specialist-batched#1 reader=security
Review-Finding: p1/specialist-batched#2 reader=testing
Review-Finding: p1/red-team#1 reader=red-team
Review-Finding: p1/red-team#2 reader=red-team
Review-Finding: p1/red-team#3 reader=red-team
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* fix: pre-landing review fixes (Step 11: re-check refuses binary paths and packets over 64 KB; fingerprint trailers bind findings with a ledger_id; the runs fence closes only on its own line)

Review-Finding: v/outside-voice#1 reader=outside-voice
Review-Finding: v/outside-voice#2 reader=outside-voice
Review-Finding: v/adversarial-native#1 reader=adversarial-native
Review-Finding: v/targeted#1 reader=targeted
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* docs: J1 re-check eligibility names every refusal (review fixes)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* test: explicit timeouts on the re-check and result-head CLI tests (each spawns several git and bun runs; the carry tests ran past bun's 5 s default locally)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

* ship: trim 11 skeleton bytes so the merged tree fits the 61,420 cap (GSTA-258 L4)

The rule 19 merge of main 1ccab0d put #3929's push-guards wording (61,418 on
main) together with J1's head=<sha> in the GSTACK_RESULT line, measuring 61,429.
Three rewordings beside that line bring the skeleton back to 61,418; the branch
ledger entry drops by 11 and the ship goldens are regenerated.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

---------

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant