Skip to content

v1.94.26.0 gstack-evidence: sum sharded bun lanes; docs: dispatch-carry warning and record-ci recheck order (GSTA-258 L6 follow-up) - #3934

Merged
capy-ai[bot] merged 22 commits into
mainfrom
gsta258-l6-carry-followup
Nov 3, 2026
Merged

capy-ai[bot] merged 22 commits into
mainfrom
gsta258-l6-carry-followup

Conversation

@garrytan

@garrytan garrytan commented Nov 3, 2026 •

Copy link
Copy Markdown
Owner
{
  "schema_version": 1,
  "pr": 3934,
  "head": "39b1c59babb2d0fb800cf6d406fedc479a936902",
  "version": "1.94.17.0",
  "base": "main",
  "gate": {
    "free": {
      "pass": 1560,
      "fail": 0
    }
  },
  "ci_carried": [
    {
      "lane": "free",
      "run": 41662215702,
      "attempt": 1,
      "tree": "5503511f3b64b97c2e5c8bd6ea413220c8dff5a8"
    }
  ],
  "session_kind": "unattended",
  "head_tree": "5503511f3b64b97c2e5c8bd6ea413220c8dff5a8",
  "product_patch_id": "899d096a33f846ab443ae5a7b5667e24036753a0",
  "gstack_version": "1.94.19.0",
  "review_depth": {
    "depth": "light",
    "class": "code",
    "runtime_lines": 92,
    "rules": "19881e1ecf7ed1ad",
    "base": "a1da77e6d45320f5066fd2438d928fc94b36ab73",
    "registry": "a1da77e6d45320f5066fd2438d928fc94b36ab73",
    "gate_scan": {
      "tagged": 0,
      "head": "39b1c59babb2d0fb800cf6d406fedc479a936902"
    },
    "reasons": [
      "runtime=92"
    ],
    "risk": []
  },
  "pregate": "requires-remote cleared @5503511f3b64 (7 checks, current for 39b1c59babb2)",
  "requires_remote": [
    "free-tests.yml/macos-named-regressions: https://github.com/garrytan/gstack/actions/runs/41662215702/attempts/1",
    "pregate.json/remote_gate: remote-gate tree=5503511f3b64 tests=34814 skipped=70 runs=41662215702/1 profiles=ci-reuse/free-tests heads=39b1c59babb2 verified=2026-11-03T15:23:05.049Z"
  ],
  "issues": {
    "fixes": [],
    "refs": [
      3923,
      3929,
      3934
    ],
    "flakes": []
  },
  "docs": {
    "status": "current",
    "scope": "merged docs/pregate.md (#ci-carry, #ship-lanes-jobs, #ship-lanes-aliases, #prove-a-mapping, #skipped-files, #skippable, #guard-carry, #dispatch-carry, #flaky-exception; audits l6fdocs3 and re-audit l6fdocs4), CONTRIBUTING.md, docs/standalone-binaries.md, docs/troubleshooting.md"
  },
  "review_loop": {
    "passes": 2,
    "blocking_found": 2,
    "deferred": 0,
    "noted": 3,
    "fixed": 4,
    "scope": "frozen",
    "fix_checks": 2,
    "rounds": 4,
    "ledgers_read": 4,
    "dispatches": {
      "specialist": 2,
      "red-team": 1
    }
  },
  "review_loop_exception": {
    "accepted_by": "GStack Minder",
    "date": "2026-11-03",
    "via": "GSTA-258 (GSTA-36 choice A, #3934 merge-tree hint)",
    "reason": "attach the base-moved hint to the :213 tree_mismatch refusal when it's a pull_request run whose rec.sha tree equals rec.tree; replace the fixture with a failing-first one that records the merge tree; one scoped fix-check on that hunk as #3934's second exception, no further rounds",
    "fix_check": {
      "head": "39b1c59babb2d0fb800cf6d406fedc479a936902",
      "findings": 0,
      "files": [
        "lib/run-evidence.ts",
        "test/ship-ci-carry.test.ts",
        "docs/pregate.md"
      ]
    }
  }
}

Summary

  • A lane whose command runs several bun test --shard=i/N processes now records the sum of the shards' counts, not the last shard's (GBEV-3, gbrain-evals#317: 3336 recorded against 6,095 run across 2 shards). The sum needs shards 1/N to N/N, in order, at the end of the log; any other set records the last summary as before. Shard and count lines that scroll out of the 64 KiB output tail are kept, so a long shard run still sums.
  • When a pull_request Free Tests run tested a merge commit because the branch was behind main, CI_CARRY: none (… tree_mismatch …) now prints the one-command fix: gh workflow run <workflow> --ref <branch>, then gstack-ci-carry wait (TRUT-7).
  • docs/pregate.md#dispatch-carry warns that a workflow_dispatch run reports under the same job names on the head commit, so without strict branch protection a green dispatch run can hide a red merge-commit check.
  • docs/pregate.md#skipped-files names the order of record-ci's checks after a skipped-file remainder, including the final tree_changed recheck.

Why

gbrain's sharded lane recorded about half its tests, so a carried lane under-reported coverage. TRUT-7 hit the bare tree_mismatch refusal on a real pull request and had to work out the dispatch fix by hand.

Blast radius

bin/gstack-evidence (test-count parsing), lib/run-evidence.ts and lib/ci-carry.ts (refusal text only: no refusal becomes a carry), and docs. No network calls, secrets, permissions, workflows or dependencies change.

Test Coverage

  • test/evidence.test.ts: two --shard=i/2 processes in one log record 6095, two shards with more than 64 KiB of per-test lines record 4000, and an incomplete, repeated or rerun shard set records the last summary. The sum cases failed before the change.
  • test/ship-ci-carry.test.ts: a pull_request run whose tree.json records a real merge commit and its tree prints the base-moved reason and the dispatch command. It failed before 39b1c59 with the bare tree_mismatch the real run printed.

Pre-Landing Review

REVIEW_LOOP: passes=2 blocking_found=2 deferred=0 noted=3 fixed=4 scope=frozen unrecorded=0 ledgers_read=4 fix_checks=2 dispatches=3

Light depth (code class). Pass 1 found one CRITICAL (shard blocks scrolled out of the 64 KiB tail, so the sum silently fell back) plus two Low notes. All three were fixed in 65ae8d4. Pass 2 found nothing. After the merge with main, a standing fix-check on the docs audit's edit found one CRITICAL. The base-moved hint sat on a check real runs never reach, because CI's tree.json records the merge commit's tree, so the earlier rec.tree check refused first with no hint. 39b1c59 moves the hint onto that refusal for pull_request runs whose recorded sha's tree is the recorded tree. A scoped fix-check on that hunk found nothing at the floor.

Review-loop exception: accepted by GStack Minder 2026-11-03 via GSTA-258 (GSTA-36 choice A, #3934 merge-tree hint): attach the base-moved hint to the :213 tree_mismatch refusal when it's a pull_request run whose rec.sha tree equals rec.tree; replace the fixture with a failing-first one that records the merge tree; one scoped fix-check on that hunk as #3934's second exception, no further rounds (fix-check at 39b1c59, 0 findings)

Open notes (not fixed in this PR):

  • autoCarry in lib/pregate/index.ts cuts the CI_CARRY: none reason at 300 characters after joining up to 10 candidate refusals, so a second earlier refusal or a long branch name can push the fix: text past the cut.
  • A pull_request candidate with a mismatched tree now reads its merge commit's tree, which can fetch that commit when it isn't local (up to 10 candidates).
  • An artifact that records "tree": null with an unreadable merge sha gets the hint on its tree_mismatch; it still refuses.
  • The printed hint says "the pull request's base moved after the run", but it also fires when the branch never had the base tip.

Issues

GBEV-3 and TRUT-7 item 3 (GSTA-258 L6 follow-up).

Refs #3923
Refs #3929
Refs #3934

Documentation

Status: current. The re-audit after l6fdocs3 found the docs accurate at 39b1c59, so no edits were made.

Scope: committed diff d2e6318..39b1c59 (bin/gstack-evidence, lib/ci-carry.ts, lib/run-evidence.ts, docs/pregate.md, changelog.d fragment, two tests); no staged, unstaged or new files. Focus: commit 39b1c59's merge-tree tree_mismatch fix hint, docs/pregate.md #ci-carry, #dispatch-carry and #skipped-files, and any doc describing tests_ran as the last summary only.

Documentation health:
docs/pregate.md Current (the #ci-carry sentence matches verifyRun: only the tested-merge-commit refusals carry fix: gh workflow run free-tests.yml --ref <branch>, then gstack-ci-carry wait; other tree_mismatch mentions, #dispatch-carry and #skipped-files are accurate)
CONTRIBUTING.md Current (CI carry row accurate; no tests_ran counting claim)
docs/standalone-binaries.md Current (no tests_ran or tree_mismatch claim)
docs/troubleshooting.md Current (no tests_ran or tree_mismatch claim)
docs/designs/HONEST_WORK_GATE_INTEGRITY.md Current as a dated design record (states last-summary-wins without the GBEV-3 shard sum; not edited)
changelog.d/gsta258-l6-carry-followup.md Read only (tree_mismatch line slightly narrower than code; see decisions)

Coverage debt: the tree_mismatch fix hint and the bun shard-set sum have reference coverage only (docs/pregate.md, changelog fragment), with no how-to. Diagram drift: none.

GSTA-258 condition met: audit l6fdocs3 read the whole merged docs/pregate.md, both #3911's flaky-exception section and #3929's sections, and found them current apart from one edit.

Test plan

  • CI green at 39b1c59; Free Tests run 41662215702 carried: LANE: free carried run=41662215702/1 tests_ran=1560 (files)
  • gstack-pregate verify ok on the stamped tree; remote gate cleared from run 41662215702 (skipped=70), macOS lane from the same run
  • Focused tests: test/ship-ci-carry.test.ts, test/ci-carry.test.ts and test/run-evidence.test.ts green; tsc clean

garrytan and others added 17 commits November 3, 2026 05:55
…CI or the ledger (GST-1186)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ulate proof, policy-base check on carried (GST-1189, GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…tree.json records skipped_files (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… find --policy-from head --simulate (GST-1190)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…rom #3923 per GSTA-258)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…(gate inputs, passed ignores CI rows, simulate consent, pull_request-only skips, guard not-owed)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…nnot print

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…h per_file

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ns must still stand (l6c-p2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…'s count must come from this run's row (l6c-p2 red-team)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…check ratchet

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…r_file move to the adoption PR; Step 17 keeps its refs/heads marker

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…oubleshooting (docs audit l6cdocs2)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…mainder run recheck (#3929 second fix-check)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…s: dispatch-carry warning and record-ci recheck order (GBEV-3, GSTA-258 L6 follow-up)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…l; sum only shards 1..N in order; soften the dispatch-carry mechanism claim (l6f-p1 fixes)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ispatch fix (TRUT-7)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…owup

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>

# Conflicts:
#	docs/pregate.md
#	lib/pregate/index.ts
#	lib/pregate/run-check.ts
#	lib/run-evidence.ts
#	test/ship-ci-carry.test.ts
@capy-ai
capy-ai Bot changed the base branch from gsta258-l6-guard-carry to main November 3, 2026 14:24
@capy-ai
capy-ai Bot marked this pull request as ready for review November 3, 2026 14:24
@trunk-io

trunk-io Bot commented Nov 3, 2026 •

Copy link
Copy Markdown

😎 This pull request was merged.

@github-actions github-actions Bot changed the title gstack-evidence: sum sharded bun lanes; docs: dispatch-carry warning and record-ci recheck order (GSTA-258 L6 follow-up) v1.94.17.0 gstack-evidence: sum sharded bun lanes; docs: dispatch-carry warning and record-ci recheck order (GSTA-258 L6 follow-up) Nov 3, 2026
@capy-ai capy-ai Bot closed this Nov 3, 2026
@capy-ai capy-ai Bot reopened this Nov 3, 2026
garrytan and others added 2 commits November 3, 2026 14:58
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ase-moved fix (the real tree_mismatch path; #3934 fix-check)

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@github-actions github-actions Bot changed the title v1.94.17.0 gstack-evidence: sum sharded bun lanes; docs: dispatch-carry warning and record-ci recheck order (GSTA-258 L6 follow-up) v1.94.26.0 gstack-evidence: sum sharded bun lanes; docs: dispatch-carry warning and record-ci recheck order (GSTA-258 L6 follow-up) Nov 3, 2026
@capy-ai
capy-ai Bot merged commit 7caca33 into main Nov 3, 2026
50 checks passed
garrytan added a commit that referenced this pull request Nov 3, 2026
lib/run-evidence.ts: #3934 (7caca33) adds head_branch to ApiRun on the
repository line; drop this branch's copy on the first line so the type has
one definition.

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant