Repository navigation
feat: retire /investigate after a no-gain eval (GST-1717) - #4110
Merged
Merged
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…GST-1717) The retired /investigate rule became 'Bugs/errors → fix them directly', which no longer matches '→ invoke /', so proactive=core leaked it into the offered section. Match any '- … → ' rule line. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…(GST-1717) The pin names replay GSTA-224 H1; a reviewer checklist edit merges only after a passing no-loss replay (crew rule 15). The /investigate flake line stays until a replayed repin. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
CI run 42340956269 at 83a8a9a: drop fixtures, ledger rows, allowlist entries and counts for the retired skill and its deleted paid files; record the harness change as non-behavioral; the test-of-test detector accepts path.join(ROOT, 'bin'); uncovered-prompt fixtures use a tracked prompt, since an untracked path now reads as a deleted one. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…it (GST-1717) With the skill's source gone, the customized-file check never ran, so a banner-carrying local copy of investigate/SKILL.md was deleted instead of moved to the backup root (red-team review, pass 1). Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
review/checklist.md keeps its pinned /investigate line, so the QM edition needs its replaceText rule back; qm/ stays fresh against the generator. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… pinned checklist line (GST-1717) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… deleting it (GST-1717) Scoped fix round under grant a-360dd62bd46a (outside-voice blocking finding and adversarial #1, #4). setup's prune compares a copied host entry with the render before removing that render, and backs up a copy that differs or whose render is gone; relink no longer takes the marker's rm -rf for a skill whose source is gone, so a real SKILL.md is backed up and the user's files stay. setup reports a failed remove-source of the retired gate hooks on stderr. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…one from disk (GST-1717) An untracked prompt file on disk still needs prompt validation (targeted review finding); harness change recorded as non-behavioral. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ST-1744 (GST-1717) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…GST-1717) Under grant a-c95576b8b1f9 (fix-check#1): every copy host moved its gstack-investigate/SKILL.md to the same backup path, so a later host's copy overwrote an earlier host's edits. A sandboxed ./setup --host factory run showed gen-skill-docs removes the retired render before the prune, so every real copy is backed up; each host now gets its own folder. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…(GST-1717) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…1717) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ral waiver (GST-1717) pregate's literals check read the GSTACK_RETIRED_SKILLS change as an old value still in the tests. plan-eng-review is still retired; investigate was appended. The fixture names it once, with the waiver. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…t, GStack Minder 2026-11-07) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2 of 3 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
/investigateis retired. It no longer installs on any host, and the next./setup, relink or upgrade removes an existing gstack-ownedinvestigate/gstack-investigateentry, even though the skill's source is gone. A user's own skill under that name is left alone. Bug reports now get fixed directly. The agent makes one read-only check of the cause, and when it is still unclear, a focused test that fails on the bug before any edit, then the root-cause fix and a rerun.Why
Garry approved the cut on 2026-11-07 ("do it" on A1, R48 CUT). A preregistered eval found no gain. On 18 real bug-fix tasks that plain Opus 5.5 solves about half the time, 20 trials each, Opus told to use /investigate passed 50.0% of trials against 47.2% with no skill (+2.8 points, 95% CI -5.8 to +11.4, MDD 10), and a passing fix cost about 43% more (GEVA-380 R3c).
Blast radius
The change touches the router, the CLAUDE.md routing block gstack offers,
/ship's test-failure triage,/ios-fix,/learn,/verify, setup, relink, the install registry and the docs. It is safe because the retire path is #4108's (RETIRED_SKILLS,GSTACK_RETIRED_SKILLS), plus one relink loop for a retired skill whose source no longer exists, proved bytest/retired-skills.test.ts(two of its tests fail against main's relink and registry). Evidence rung: script ran.Approvals
Approved: yes (record r-6c5eb42b9094). The full approval record stays private: this repository is public or its visibility is unknown.
Summary
scripts/discover-skills.tsandbin/gstack-install-registry.shlistinvestigateas retired, so config can't re-enable it.bin/gstack-relinknow cleans<skills>/investigateand<skills>/gstack-investigatefor every retired skill, because a deleted source never reaches the main loop. The OpenClaw and QM editions drop their investigate skills.lib/investigate-gate.tsand its switch ingstack-config,gstack-skill-gatesandgstack-skill-routeare gone../setupremoves the gate's four settings entries on every run; theKNOWN_HOOKSrows stay so the old entries are still recognized as gstack's.skill-contract-stop-hookandlib/skill-contract.tsstay for/review's contract;lib/skill-gates.tsstays for the/plan-ceo-reviewand/autoplangates.lib/ceo-review-gate.tscarries its own git helpers instead of importing them from the deleted gate.ROUTED_SKILLSis now review, qa and verify.bin/gstack-skill-start, CLAUDE.md,/ship(triage and the Blast radius evidence-ladder rungs, now inline),/ios-fix,/learn,/verify,review/checklist.md, the gbrain and question registries, the doctor components and the docs all point at fixing directly.docs/skills.mdgets a/investigate(cut) note with the evidence link.PR profile requires full validationfor a file with no prompt left (scripts/test-pr-profile.ts; the new test fails without the fix).careful/bin/hook-extract.shis free-only now that its only paid consumers retired.Paid cases
CARVE_GUARDS.investigateremovedNone of the retired cases was quarantined, so the
CASE_QUARANTINEexit rule does not apply; each is removed fromE2E_TOUCHFILES,E2E_TIERS,E2E_KINDS, the host map, the exercised-command map and the duration files, with this table as its record. The retired fallback router cases leave the unclear-cause path ("failing test first") with no paid negative control.Test Coverage
CI at 754d2e6 is green: 36 checks passed, 0 failed, 0 pending. The free suite ran 1623 test files in run 42347452222, carried as CI_CARRY at tree 33ae5a841a6e. The macOS and Windows lanes cleared the pregate's requires-remote obligations. Local focused runs of
test/retired-skills.test.tsand the two merge-resolution test files were green. The three changed paid cases ran once each under Claude Code 2.1.292 (run loggst1717-routing) and each passed, for $0.21 total.Pre-Landing Review
REVIEW_LOOP: passes=1 blocking_found=2 deferred=1 noted=8 fixed=4 scope=frozen fix_checks=4 rounds=5
Both blocking findings were fixed with failing-first tests. They were the prune data-loss case and the per-host backup collision. The final adversarial pass at e1ef7d8 found 3 Low items and the outside voice found none. The two later fix-checks (acdd017 and 754d2e6) came back clean.
Review-loop exception: accepted by GStack Minder 2026-11-07 via a-f2a51169043f: merge-resolution hunks after the rule-13 merge of main: two test files (fix-check at 754d2e6, 2 findings)
Open notes, none blocking:
bin/gstack-relinkstill removes a markedinvestigatedirectory when a stale render survives a failed re-render.investigate/sections/folder./and_.scripts/test-pr-profile.ts:499checks deletion against the selector's checkout, not the reviewed tree, and exempts a deleted prompt that is still referenced.bin/gstack-relink:269has danglingsections/links,docs/CONTRIBUTOR_REFERENCE.md:86names the old backup path, andtest/skill-gates-advisory-bytes.test.ts:23dropped the plan-ceo-review source scan.review/checklist.md:129still names /investigate on purpose until GST-1744.Documentation
Status: current. Audit ship4110-docs-a1 covered base 3742ee9 to e1ef7d8, and re-audit ship4110-docs-a2 covered the main merge in 754d2e6. Every authored doc already describes /investigate as retired, so neither audit made edits. Debt: the generated
docs/inventory.mdstill lists investigate untilbin/gstack-inventoryregenerates it.