Skip to content

Update INCIDENTS.md fixture to cite renamed How to work test (#3840) - #4151

Closed
ElNeMeR70 wants to merge 1 commit into
garrytan:mainfrom
ElNeMeR70:fix/incidents-fixture-phase1-test-name-3840
Closed

ElNeMeR70 wants to merge 1 commit into
garrytan:mainfrom
ElNeMeR70:fix/incidents-fixture-phase1-test-name-3840

Conversation

@ElNeMeR70

@ElNeMeR70 ElNeMeR70 commented Nov 8, 2026 •

Copy link
Copy Markdown
Contributor

Updates the stale test-name citation on line 35 of the incidents fixture so it matches the renamed test and substring in test/investigate-recipes.test.ts. This keeps the incident catalog aligned with the current test suite.

Details

  • Updates test/fixtures/multi-agent-wave/INCIDENTS.md line 35 (p1-7-stale-index-timing) to cite investigate How to work and "How to work lessons" in test/investigate-recipes.test.ts:103-112 instead of the pre-rename investigate Phase 1 / "Phase 1 lessons" names.

Fixes #3840

@trunk-io

trunk-io Bot commented Nov 8, 2026

Copy link
Copy Markdown

Merging to main in this repository is managed by Trunk.

  • To merge this pull request, check the box to the left or comment /trunk merge below.

After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here

@ElNeMeR70
ElNeMeR70 force-pushed the fix/incidents-fixture-phase1-test-name-3840 branch from a9c5844 to 1016f6b Compare November 8, 2026 02:58
@ElNeMeR70 ElNeMeR70 changed the title fix(test): update INCIDENTS.md fixture to cite renamed How to work test (#3840) Update INCIDENTS.md fixture to cite renamed How to work test (#3840) Nov 8, 2026
@capy-ai

capy-ai Bot commented Nov 8, 2026

Copy link
Copy Markdown
Contributor

Thanks for catching the stale citation. Since you opened this, #4110 (shipped in v1.98.0.0) retired /investigate and deleted test/investigate-recipes.test.ts, so the test this row would cite no longer exists and the change can't land as written. Closing it as superseded by #4110. The fixture row itself is still tracked in #3840.

@capy-ai capy-ai Bot closed this Nov 8, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Deferred review finding: test/fixtures/multi-agent-wave/INCIDENTS.md:35 — Fixture cites the renamed Phase 1 test name

1 participant