Repository navigation
Conversation
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
This was referenced Nov 9, 2026
A carry treated every edit under test/ as harmless, so a loosened assertion rode a test-only carry to land unread. A carry whose test diff removes or changes assertion lines now refuses with RECEIPT_CARRY_TEST_WEAKENED naming the hunks and carries only after one scoped fix-check bound to its packet. The land merged-checks list and the touchfile maps count as product for a carry. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Review-Finding: bin/gstack-doctor-components.sh:340:enum-completeness reader=core Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…spawn the receipt script Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
garrytan
force-pushed
the
receipt-carry-refuses-weakened-tests
branch
from
November 9, 2026 23:50
c48c072 to
7d6be7a
Compare
…t eval policy, budgets and ratchet allowlists as gate files A base removal used to cancel a branch removal whenever the assertion text matched, so the base dropping an expect from one test could hide the branch dropping the same expect from another. Removals now match only within the same test at the same place. The paid-eval policy and budget data and the ratchet allowlists join the land list and touchfile maps as gate files a test-only carry cannot hold. Review-Finding: v1/outside-voice#3 reader=outside-voice Review-Finding: v1/adversarial-native#3 reader=adversarial-native Review-Finding: v1/targeted#2 reader=targeted Review-Finding: p1/red-team#1 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
The gate-file check was skipped when a stacked child is retargeted after its parent lands, so the child could empty the land list after review and still carry. On that route each gate file must now match the reviewed head byte for byte. Review-Finding: v1/outside-voice#1 reader=outside-voice Review-Finding: v1/adversarial-native#4 reader=adversarial-native Review-Finding: v1/targeted#1 reader=targeted Review-Finding: p1/specialist-batched#1 reader=security Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
The check reads removed or rewritten assertion lines only. The docs and changelog now name what still carries as test-only: a value changed inside a multi-line matcher, an added early return, and golden or snapshot edits. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
2 tasks done
Contributor
|
Closing this for now. The check that stops a test weakened after review from merging without a reviewer is parked until the design for owner rulings on review findings (GST-2273) lands. The branch stays at 1556ce2 and keeps the review fix round, so the work can be picked up from there. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A receipt carry no longer lets a test that was weakened after review merge without anyone reading it. This closes a hole in the merge checks (GSTA-461 audit item 6).
What changed
gstack-ship-receipt carryused to treat every edit undertest/as harmless. After /ship, a lane could changeexpect(a).toBe(1)toexpect(typeof a).toBe('number'), carry the receipt as a "test-only change", and land with CI green and no reviewer. Now a carry whose test diff removes or changes an assertion line (anexpect,assertor matcher, or atest(...)/it(...)line) refuses withRECEIPT_CARRY_TEST_WEAKENED. The refusal names each hunk aspath:lineand writes a packet for one scoped fix-check. The carry goes through once--test-review <record.json>holds a clean verdict bound to that head and the packet's sha256.test/land-merged-checks.txt(the list land runs on a moved base) and the touchfile maps undertest/helpers/now count as product for a carry. Emptying or editing them isRECEIPT_CARRY_PRODUCT_CHANGED, not a test-only change.#receipt-carry-test-weakened), a row in docs/ship-policy.md's carry table, agstack-ship-preflightroute line and a changelog fragment.Tests
test/ship-receipt-carry-weakened-test.test.tswas written first from the audit repro. On main, the repro carried and the gate-path and parser cases failed (6 of 9 failed). On this branch all 9 pass. The negative controls are a pure test addition, a base-side assertion change andtest.skip.Agent notes
lib/ship-carry-tests.ts. It reads removed lines in the zero-context diff from the reviewed head to HEAD, minus lines the base removed itself, plus lines the branch's current patch drops that its reviewed patch didn't (an assertion a base merge brought in that the branch then removed).test.skipand deleted tests keep their stronger refusal (/ship).comparePath) because the product patch-id pathspec can't re-include a path under an excludedtest/**glob.planCarrynow refuses wheneverchangedProductis non-empty, even when the patch-ids match. This changes nothing for existing callers, which filledchangedProductonly when the patch-ids differed.returnor a new mock is an added line and still carries (the gate scan and CI cover those). Retargeted stacked children skip the gate-path comparison.