Repository navigation
Conversation
…, as the review policy says (GST-2273) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… never by a bare ledger id (GST-2273) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…273) Merges main (e9f38d6, with #4360). Resolving the conflicts with GST-2491's gate dispositions also fixes the three wrong closes from the cross-family audit of 36ce6ad: a fingerprint two findings share closes neither (ruledFinding, summary key counts), a ruling applies only at the commit the row read (not anywhere in range_base..commit), and the summary takes rulings only from a via:ship row. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…ulings (GST-2273) ledgerBlockers now carries gate and gate_id from the reader's line (its JSON gate field, or an RH tag it names), and the review-loop summary never counts a ledger-only gate finding as noted. Found by the read-only /ship review of #4272 at fa3e4a2 (outside voice and Red Team). Review-Finding: p1v/outside-voice#1 Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Merging to
After your PR is submitted to the merge queue, this comment will be automatically updated with its status. If the PR fails, failure details will also be posted here |
2 tasks done
… a finding the owner can actually rule (GST-2273) gstack-review-read and gstack-review-scope summary warn and apply no rulings when the approvals store can't be read, instead of crashing. FIX_CHECK_OPEN names each held finding by a key only it uses on the row, so two findings that share a fingerprint are named by their ledger ids. A legacy stopped read with no start commit binds only when its commit is from an earlier second than the read's start. Review-Finding: p1/specialist-batched#1 reader=testing Review-Finding: p1/specialist-batched#2 reader=state-machines Review-Finding: p1/red-team#1 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…two share a fingerprint (GST-2273) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Contributor
|
Superseded by #4446, which rebuilds this change off main with a narrower design: an owner's ruling closes only the one finding it names by ledger id, at the head it names. The three wrong closes the second-model audit found on this PR's head are tests there. This branch is kept. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner's ruling now closes a finding on a round-2 full pass and on a cross-model (Step 11) finding, as docs/review-policy.md already promises, and it closes only the finding and the head the owner named. This supersedes #4272, which a cross-family audit held because rulings there could close more than the owner ruled.
Why
Before this change, only the narrow re-check after a fix read the owner's rulings. Crews parked #4248, #4266, #4257 and harness-evals#361 at the round cap with the owner's ruling recorded and nothing applying it. #4272 added that, but the audit of its head 36ce6ad (handoffs/GSTA-495/sol-audit-36ce6ad.md in the Captain's drive) showed three wrong closes. /ship's read-only review of the rebuilt head fa3e4a2 then found a fourth: a gate finding that only a dispatch ledger holds could be ruled. #4272 was at its review-round cap, so the fix ships here as a fresh PR with its own review.
Summary
gstack-review-readapplies each approvedgstack-approvals rulemade at the commit a review row read, so a round-2 full pass whose only blocker is ruled readsCURRENT.gstack-review-scope summarycounts a ruled finding that no row records asnotedinstead ofunrecorded.ledgerBlockerscarriesgateandgate_idfrom the reader's line.GSTACK_CAPY=1.Blast radius
Review-binding code only: lib/review-evidence.ts, lib/ruled-notes.ts, lib/review-scope.ts, lib/review-ledger.ts, lib/ship-release.ts, lib/approval-record.ts, bin/gstack-review-read and bin/gstack-review-scope. What counts as blocking doesn't change, and every ruling still needs an approved owner row. test/ship-ruled-full-pass.test.ts holds the negative controls. Its five audit cases fail at #4272's 36ce6ad and pass here (script ran).
Supersedes #4272. Refs GST-2273.
Test Coverage
Coverage audit only (no tests written in /ship): every changed code file has a changed or referencing test; the five audit cases in test/ship-ruled-full-pass.test.ts fail at #4272's 36ce6ad and pass here.
Tests ran: free 37396 (from CI, free-tests run 44082060540 at e34f9b5)
Pre-Landing Review
Pass 1 (specialist, Red Team, second-model review by openai/gpt-6.1-sol) found 3 findings, all fixed in 1a51796: reviews keep reading when rulings can't be read, and the fix-check refusal names a finding the owner can actually rule (its ledger id when two share a fingerprint). Pass 2, a full pass over the fix, came back clean.
REVIEW_LOOP: passes=2 blocking_found=0 deferred=0 noted=1 fixed=3 scope=frozen ledgers_read=4 dispatches=8
Second-model review: completed (openai/gpt-6.1-sol).
Review notes
Below the blocking floor; recorded here and not fixed in this PR.
lib/ruled-notes.ts:58a stopped read logged before reads captured their start commit now binds only when its commit is from an earlier second than the read's start; nothing tests that boundary.Eval Results
No prompt-related files changed, so evals were skipped.
Plan Completion
Plan: exempt: bug fix
Issues
Refs #4271
Refs #4272
Refs #4360
Refs p1/red-team#1
Refs p1/specialist-batched#1
Refs p1/specialist-batched#2
Refs p1v/outside-voice#1
Documentation
Status: updated. One factual fix, no blockers.
Scope: base e9f38d6 to head 84261bf, 8 commits and 14 files (owner rulings close findings on full passes and Step 11 voices, GST-2273). No staged, unstaged or new files. Docs the diff touches were checked against lib/ruled-notes.ts, lib/review-evidence.ts, lib/review-scope.ts, lib/review-ledger.ts, lib/approval-record.ts, lib/ship-release.ts, bin/gstack-review-read and bin/gstack-review-scope.
Documentation health:
Coverage debt: gstack-review-read and gstack-review-scope summary now apply rulings: reference coverage is in ship-policy.md, how-to coverage is in troubleshooting.md, and no tutorial is needed. The new error text (rulings unreadable, none applied) has no troubleshooting entry. That is a minor gap.
Diagram drift: none. No diagrams cover these modules.
Test plan
bun run test(free lane): from CI, free-tests run 44082060540 at e34f9b5, greenbun test test/ship-ruled-full-pass.test.tsand the adjacent review-ledger, review-scope and ship-review-loop files: 106 pass, 0 fail at 914dc16Agent notes
Approvals
No approvals recorded for branch capy/owner-rulings-close-only-what-they-name-gst-2273.
Plan: exempt: bug fix