Repository navigation
Helper hooks are on by default, the destructive-command check runs as a hook, and prompt routing fires on long bug reports (GST-3110) - #4503
Merged
Conversation
… a hook, and prompt routing fires on long bug reports (GST-3110) Prompt routing, skill contracts and the new destructive-command hook register by default in Claude Code; OpenClaw and Hermes get the start hook. An off the user set earlier is kept. The routing matcher scores long prompts on head and tail windows, reads defect words as bug and keeps paths whole: 40 of 60 bug prompts route instead of 22, and 0 of 60 plain prompts. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…pt runner Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…tory Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…r config stays off on later runs Review-Finding: p1v/outside-voice#1 reader=outside-voice Review-Finding: p1v/adversarial-native#4 reader=adversarial-native Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… off Review-Finding: p2/red-team#1 reader=red-team Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…er headless sessions An ask in a session nobody watches waits for an answer that never comes. CLAUDE_CODE_ENTRYPOINT=sdk-cli (claude -p) or a headless gstack-session-kind now gets the reason as a warning and the command runs; interactive sessions keep the ask, and a deny stays a deny. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
The start hook defaults to on only for new registrations. An off saved before the default changed stays off, and the first refresh prints once how to turn it on (gstack-harness register <harness> --start-hook). Only an off gstack recorded because it refused the hook gives way to the default. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
… runs warn instead of asking; docs match the new defaults A registration record written before gstack had a start hook has no start_hook field and fell through to the new on default, so an upgrade turned the OpenClaw or Hermes hook on. An existing record now counts as off. The destructive-command hook treats every Agent SDK entrypoint (sdk-cli, sdk-ts, sdk-py) as a session with nobody to answer an ask. install.md, skills.md, uninstall.md, the routing dry-run example and the README /careful row now describe the on-by-default hooks. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…laude -p counts as headless An interactive Conductor session also reports CLAUDE_CODE_ENTRYPOINT=sdk-ts, so the entrypoint cannot tell an unattended SDK run from a person watching. Back to sdk-cli only, with a test that a Conductor sdk-ts session still gets the ask. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This was referenced Nov 18, 2026
Merged
capy-ai Bot
added a commit
that referenced
this pull request
Nov 19, 2026
- `gstack-artifact validate` no longer passes a run.json that gstack-autoplan never wrote. (#4494) - /ship's changed-number check no longer stops on tests that only share a word with the change (#4478). (#4496) - On Capy, /ship no longer edits or comments on pull requests as you. (#4518) - The destructive-command check stops asking about scratch deletes and catches the real damage it used to miss. (#4513) - The destructive-command check reads commands more carefully, closing gaps found after the last release. (#4525) - The Codex readiness check and the second-model review now pick the same model for a custom Codex provider (GST-3089). (#4491) - gstack's Codex hooks work when your Codex folder's path has a `(`, `&` or other shell character in it. (#4528) - Uninstalling gstack keeps your own Codex hooks trusted. (#4528) - Codex hook setup matches Codex more closely. (#4528) - On Windows, setup copies the Claude Code hook code that gstack's Codex hooks import (#4528) - /review's checklist on Codex reads shell commands more carefully. (#4528) - On Codex, gstack now suggests the right skill for a prompt and stops destructive commands before they run. (#4512) - On Codex, /review is now held once when it tries to finish without its adversarial pass or its report, as it already is on Claude Code. (#4522) - On Codex, gstack's skill suggestion now names the skill the way Codex lists it. (#4523) - On Codex, gstack's suggested prompts and docs now name skills the way Codex lists them. (#4524) - /review on Codex with gpt-6.1-sol is no longer held back for a second-model pass it already ran. (#4526) - On Codex, office-hours, plan-design-review and gstack-upgrade work again when you name them. (#4510) - gstack knows when Codex is running unattended. (#4510) - Codex reviewers start with a clean context. (#4510) - Docs no longer say Codex has no hook support. (#4510) - A command whose output was cut off no longer counts as a finished read. (#4492) - A folder marked as published data can no longer hide source code or agent files from /ship's review. (#4516) - Correction to the on-by-default helper hooks entry: the hook still routes only to /review, /qa and /verify, so skills you've installed yourself aren't suggested yet. With gstack's skills it routes 14 of 60 real bug reports (was 17), and long prompts are no longer skipped. (#4505) - /sync-gbrain's read check now works when the first page in your code source is over 64 KB. (#4497) - Free-suite CI no longer fails before any test runs when Ubuntu's package mirror is slow. (#4530) - Syncing a second repo no longer makes the first one ask for /sync-gbrain again. (#4532) - gstack's helper hooks are now on by default in Claude Code, OpenClaw and Hermes, and the prompt-routing hook fires on real bug reports. (#4503) - `gstack-pregate clear --receipt` accepts a remote gate run from before a merged release when the release only regenerated a declared release output. (#4483) - The second-model review now keeps the reviewer's own result, and reports a used-up budget as a budget stop. (#4515) - When the reviewer wrote its review to the result file it was asked for, Codex then replaced that file with its short closing message ("Done, I wrote the review"), so the review was thrown away and reported as missing its markers. (#4515) - When the provider refuses the call with HTTP 402 Payment Required (usually a metering proxy that hit its allowance, or an account out of credits or quota), gstack used to record only "exit 1". (#4515) - The pre-commit /verify check now fails a check that times out, and its checks share one time budget (GST-3201). (#4527) - /ship's review collector no longer reads a reviewer's own scope list or list of passed checks as findings (GST-3201). (#4527) - Merge-queue stack tests fail when git cannot list a PR's added test files (GST-3201). (#4527) - /ship can now review results PRs that publish raw session data. (#4511) - /ship's review pass works when the checkout you ship isn't the project's default checkout. (#4507) - A second review round no longer reports done when nothing was reviewed. (#4520) - The prompt-routing hook now suggests skills you install yourself, and no longer sends ordinary bug reports to /qa (GST-3123). (#4506) - gstack's script runner and merge-queue checks now also refuse cut-off output. (#4502) - A failed second-model review reports the cause that actually stopped it, and the runner never deletes its own prompt. (#4519) - `gstack-ship-queue ready` now fills in the trial merges and the second-model trail read instead of printing lines to fill. (#4529) - Five small ship-tool fixes. (#4529) - A ruling the owner gives while a `/ship` run is open can be relayed. (#4529) - /ship no longer kills a working test run as stalled when the test command starts its workers in their own session. (#4533) - /ship no longer stops a review because the state-machine reader started its reply the way its instructions say. (#4504) - When Claude Code runs /verify right before a commit, it now gets a quick check instead of the full fix loop (GST-3150). (#4508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Claude Code now gets gstack's prompt-routing, skill-contract and destructive-command hooks on by default, and new OpenClaw and Hermes registrations get the start hook. On 60 real bug reports, routing now matches a bug-fix skill on 40 (was 22), but gstack's own skills route 14 (was 17).
Why: on Opus 5.5, unattended, a hook line naming a skill got it loaded in 58 of 60 sessions, and a skill relying on its description in 0 of 60 (gstack-evals#369).
To opt out:
gstack-config set skill_routing off(orskill_contracts,destructive_guard,harness_start_hook); an off you chose before is kept.What changed: the defaults, before and after
gstack-config set skill_routing offor./setup --no-skill-routinggstack-config set skill_contracts offor./setup --no-skill-contractsclaude -pand other headless sessions it warns instead of askinggstack-config set destructive_guard offor./setup --no-destructive-guardgstack-harness register openclaw --no-start-hook, orgstack-config set harness_start_hook off./setupor/gstack-upgradeafter this lands registers each hook the person never turned off, prints one line per hook with its off switch, and once prints a notice listing what it turned on (marker$GSTACK_STATE_ROOT/.hooks-on-by-default-notice). An off set earlier by flag,gstack-configor the environment is read before the default and kept. For the start hook, every off a registration already has is kept, including a registration recorded before the start hook existed, so an upgrade never turns on a plugin that grants OpenClaw conversation access; the first refresh prints onceoff, as before: gstack now turns it on only for new registrations; turn it on: gstack-harness register <harness> --start-hook. The one off the default overrides is one gstack recorded because it had to refuse the hook (custom--skills-dir, foreignOPENCLAW_CONFIG_PATH), so the hook comes on once that cause is gone. When the default turns the start hook on and the harness can't activate it yet, registration still succeeds (no exit 4); later refreshes retry.hosts/claude/hooks/destructive-guard-hookrunscareful/bin/check-careful.shunchanged: ask for the destructive families, deny for a recursive delete of/or home and a force-push to the default branch. An ask's reason (the person reads it) adds the hook's name and off switch; a deny's reason (the model reads it) doesn't. The two deny messages no longer tell the model to "end the /careful session", which can't lift an every-session check. In a session nobody is watching (claude -p, which Claude Code marksCLAUDE_CODE_ENTRYPOINT=sdk-cli, or a headlessgstack-session-kind), an ask would wait forever, so the hook prints the reason as a warning and allows the command, the same as when the check is off; interactive sessions keep the ask and a deny stays a deny. About 0.13 s per Bash call.bashprefix on Windows, matcherBash|PowerShell); no Windows-only path changed.Prompt-routing matcher: what changed and the replay numbers
The matcher now (1) scores a prompt longer than 5,000 characters on its first 4,000 and last 1,000 characters instead of skipping anything over 8,000; (2) reads defect words (error, exception, traceback, crash, fail/failure, broken, regression, incorrect, wrong, defect, and exception names like
ValueError) as "bug"; (3) keeps paths and identifiers whole (site-packages,src/review.ts), so traceback paths stop matching trigger words; (4) prefers a whole-phrase match when two triggers of one skill tie.Replayed with no model calls on the 60 B1b bug prompts (
b1b routesfrom garrytan/gstack-evals lanes/delivery-route at 6191ded's prompts; prompt hashes identical to the preregistered route-table.tsv):_interfacesplit (mostly new-code asks; at least one reports a real bug)test/fixtures/skill-route-plain-prompts.txt, 60 prompts: features, questions, docs, refactors, ops, data, and 6 that use error/exception/failed in feature requests)Reading the remaining 20 misses by hand (not classified by the replay), most describe the defect only with "should", "instead" or "doesn't", or read like feature requests. Adding those words would route feature requests too. gstack's own routed list (/review, /qa, /verify) still has no bug-fix skill, so in a stock install a bug report routes to /verify, /qa or nowhere, and that stock routing fell from 17 to 14 of the 60 with this change; GEVA-2's measurement lists prove-it as B1b did.
Agent notes
routable_if_listedcolumn readsPROMPT_MAX_CHARS, which this change removes, so the "after" count is that column's other half (best_score >= ROUTE_THRESHOLD) from the same tool run.GSTACK_HARNESS_START_HOOKorharness_start_hookstays off silently, and the changelog's "prints one line" reads broader than that; the docs-only follow-up corrects the changelog wording, along with its "40 instead of 22" line and the exit-4 sentence in docs/hosts.md.startHookcomment still ends the order at "then the ledger".Review-loop exception: accepted by Captain GStack Minder (GSTA-36) 2026-11-18 via ruling of 2026-11-18 relayed by the lane (GSTA-627): one read-only full review of the final head 89ed42e, no fix round, per R51 and the ruling of 2026-11-18, then granted fix-checks of d5f4a63 (a-8354f1687fbd) and b35ea46 (a-4f7937d1e7ea) (fix-check at b35ea46, 0 findings)
Documentation:
Status: blocked, shipped under a documentation exception. Scope: docs/, README.md and careful/SKILL.md.tmpl against base 2f57b07 at head b35ea46 (read-only audit docs-4503-b35ea46-2). Two lines in docs/skill-routing-and-contracts.md are stale (line 18 and the Host support table); everything else this PR changed is current.
Documentation exception: accepted by GStack Minder (Captain, GSTA-36) 2026-11-18 via Captain ruling by agent message to the lane, relayed by the lane (GSTA-627): Two stale lines in docs/skill-routing-and-contracts.md are accepted as a documentation risk for #4503 at b35ea46. Line 18 says an unreadable config turns 'both' hooks off, but it turns off three. The Host support table has no column for the destructive-command check. Neither line fails a test, breaks production or loses data. They are fixed in a docs-only follow-up PR opened right after #4503 lands.