Repository navigation
Pre-commit /verify fails on a timeout, and the review collector stops reading reviewers' scope lists as findings (GST-3201) - #4527
Merged
capy-ai[bot] merged 3 commits intoNov 19, 2026
Conversation
… reading reviewers' scope lists as findings (GST-3201) A timed-out check is VERIFY FAIL and quick --timeout bounds the whole pass; a scope-list or passed-checks bullet under a reviewer's blocking=0 verdict stays informational; stack tests fail when git cannot list a PR's added tests; the spawnSync import ratchet sees default-plus-named imports. Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
😎 This pull request was merged. |
…date; verify wording drops the always-in-time claim A bullet that names severities only as a kind of finding, under a reviewer's blocking=0 verdict, now keeps its label and becomes a summary candidate the lead lowers with a reason, so "Two P0 findings remain unfixed" still blocks until judged. The quick-pass wording no longer promises the VERIFY line always prints inside 10 minutes: the test stage can still run past the budget. Review-Finding: p1/outside-voice#1 reader=outside-voice Review-Finding: p1/outside-voice#2 reader=outside-voice Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
…and the stack-test listing failure (GST-3201) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
Merged
capy-ai Bot
added a commit
that referenced
this pull request
Nov 19, 2026
- `gstack-artifact validate` no longer passes a run.json that gstack-autoplan never wrote. (#4494) - /ship's changed-number check no longer stops on tests that only share a word with the change (#4478). (#4496) - On Capy, /ship no longer edits or comments on pull requests as you. (#4518) - The destructive-command check stops asking about scratch deletes and catches the real damage it used to miss. (#4513) - The destructive-command check reads commands more carefully, closing gaps found after the last release. (#4525) - The Codex readiness check and the second-model review now pick the same model for a custom Codex provider (GST-3089). (#4491) - gstack's Codex hooks work when your Codex folder's path has a `(`, `&` or other shell character in it. (#4528) - Uninstalling gstack keeps your own Codex hooks trusted. (#4528) - Codex hook setup matches Codex more closely. (#4528) - On Windows, setup copies the Claude Code hook code that gstack's Codex hooks import (#4528) - /review's checklist on Codex reads shell commands more carefully. (#4528) - On Codex, gstack now suggests the right skill for a prompt and stops destructive commands before they run. (#4512) - On Codex, /review is now held once when it tries to finish without its adversarial pass or its report, as it already is on Claude Code. (#4522) - On Codex, gstack's skill suggestion now names the skill the way Codex lists it. (#4523) - On Codex, gstack's suggested prompts and docs now name skills the way Codex lists them. (#4524) - /review on Codex with gpt-6.1-sol is no longer held back for a second-model pass it already ran. (#4526) - On Codex, office-hours, plan-design-review and gstack-upgrade work again when you name them. (#4510) - gstack knows when Codex is running unattended. (#4510) - Codex reviewers start with a clean context. (#4510) - Docs no longer say Codex has no hook support. (#4510) - A command whose output was cut off no longer counts as a finished read. (#4492) - A folder marked as published data can no longer hide source code or agent files from /ship's review. (#4516) - Correction to the on-by-default helper hooks entry: the hook still routes only to /review, /qa and /verify, so skills you've installed yourself aren't suggested yet. With gstack's skills it routes 14 of 60 real bug reports (was 17), and long prompts are no longer skipped. (#4505) - /sync-gbrain's read check now works when the first page in your code source is over 64 KB. (#4497) - Free-suite CI no longer fails before any test runs when Ubuntu's package mirror is slow. (#4530) - Syncing a second repo no longer makes the first one ask for /sync-gbrain again. (#4532) - gstack's helper hooks are now on by default in Claude Code, OpenClaw and Hermes, and the prompt-routing hook fires on real bug reports. (#4503) - `gstack-pregate clear --receipt` accepts a remote gate run from before a merged release when the release only regenerated a declared release output. (#4483) - The second-model review now keeps the reviewer's own result, and reports a used-up budget as a budget stop. (#4515) - When the reviewer wrote its review to the result file it was asked for, Codex then replaced that file with its short closing message ("Done, I wrote the review"), so the review was thrown away and reported as missing its markers. (#4515) - When the provider refuses the call with HTTP 402 Payment Required (usually a metering proxy that hit its allowance, or an account out of credits or quota), gstack used to record only "exit 1". (#4515) - The pre-commit /verify check now fails a check that times out, and its checks share one time budget (GST-3201). (#4527) - /ship's review collector no longer reads a reviewer's own scope list or list of passed checks as findings (GST-3201). (#4527) - Merge-queue stack tests fail when git cannot list a PR's added test files (GST-3201). (#4527) - /ship can now review results PRs that publish raw session data. (#4511) - /ship's review pass works when the checkout you ship isn't the project's default checkout. (#4507) - A second review round no longer reports done when nothing was reviewed. (#4520) - The prompt-routing hook now suggests skills you install yourself, and no longer sends ordinary bug reports to /qa (GST-3123). (#4506) - gstack's script runner and merge-queue checks now also refuse cut-off output. (#4502) - A failed second-model review reports the cause that actually stopped it, and the runner never deletes its own prompt. (#4519) - `gstack-ship-queue ready` now fills in the trial merges and the second-model trail read instead of printing lines to fill. (#4529) - Five small ship-tool fixes. (#4529) - A ruling the owner gives while a `/ship` run is open can be relayed. (#4529) - /ship no longer kills a working test run as stalled when the test command starts its workers in their own session. (#4533) - /ship no longer stops a review because the state-machine reader started its reply the way its instructions say. (#4504) - When Claude Code runs /verify right before a commit, it now gets a quick check instead of the full fix loop (GST-3150). (#4508) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-commit /verify now fails a check that times out and runs its checks on one time budget; a reviewer's scope-list bullets no longer need an owner ruling to clear; stack tests fail when git can't list a PR's tests.
Why: each let a result read clean with nothing proving it, or block on nothing (#4518, #4519). Goal: gates never pass on missing evidence.
Nothing to do;
gstack-checks quick --timeoutis now one budget the checks share (540 s default).Why
A pre-commit check that ran out of time was listed as "not run", so the commit still got
VERIFY PASSwith nothing proving it. A reviewer that declared no blockers still had its own list of what the tests cover collected as HIGH or P0 blockers (#4518, #4519), so the run waited on an owner ruling for nothing. A merge-queue slot whose test list git could not read passed as if it added no tests.What changed
gstack-checks quick). A check that times out is now a red:VERIFY FAIL: <check> TIMEOUT, exit 1. Before, it was listed as "not run" and the commit still gotVERIFY PASS. The checks share one deadline, so each gets the time that is left, and a check that cannot start before it is a TIMEOUT. Before, each check got its own 600 seconds. The test stage starts with the time left, but its runner can still run past it, so a very slow test run can still outlast a 10-minute Bash call; carrying the deadline into lib/pregate is a follow-up.gstack-checks runis unchanged.lib/review-ledger.ts). When a reviewer's ownREVIEW_VERDICTline declaresblocking=0, a single-line bullet with no file:line, no Severity or Blocks field, no lead label and no severity except ones naming findings as a kind ("a HIGH finding still refused", "can't occur alongside P0 or P1 findings") keeps its label and becomes a summary candidate, which the /ship lead may lower in judgment with a reason instead of needing an owner ruling. It still blocks until judged, so a bullet like "Two P0 findings remain unfixed" is never lost. Everything else parses exactly as before.crew/lib/ship-queue-stack-tests.ts). A git failure listing a PR's added test files fails the slot with git's error, instead of reading as "no new test files".test/spawn-sync.test.ts). The scanner now seesimport cp, { spawnSync }and a default import beside a named or namespace one. No file in the repo uses those forms today, so the baseline is unchanged.Blast radius
The collector change only adds a summary-candidate mark to rows that already collected; a marked row still blocks until the lead lowers it with a reason, so no row that blocked before can pass silently (read at
lib/review-ledger.ts:356-358and covered by the negative controls intest/review-ledger-scope-bullets.test.ts).gstack-checks runandstatuspass no deadline, so only the pre-commit quick pass changes (lib/checks.ts:308-311, fixture test in test/gstack-checks.test.ts).Test Coverage
Step 7 audit: 9 of 11 changed paths have a two-star or better test (82%). Gaps, proposed and not written: no test reads quick's 540-second default, and no merge-queue batch test reaches the new
QUEUE_TRAIN_STACK_REDwording for a slot whose files git could not list.Tests: 1831 → 1831 (+0 new in this run; the branch's own new tests are listed under Tests)
Tests ran: targeted 26
Pre-Landing Review
Full review of 21cd505 (specialists, red team, native adversarial, a second-model review on GPT-6.2 Sol, targeted reader): two findings. The collector's first version relabelled a bullet that asserts an open blocker, and the quick-pass wording promised more than the test runner keeps. Both were fixed in one granted fix round (04dbf60, docs in 2c67625); the follow-up check of that fix and the targeted reader on 2c67625 found nothing. Second-model review: completed, two findings, both fixed. Noted, not fixed: the
QUEUE_TRAIN_STACK_REDfix hint still suggests fixing or reordering tests when the real cause is a git listing failure (crew/lib/ship-queue-train.ts:579, Low).Documentation
Status: current. The docs already match the diff; no edits.
Scope: 3 commits from 45e6d54 to 2c67625, 14 files: the /verify quick-pass timeout budget, the review collector's scope-list rule and the stack-test listing failure (GST-3201). No staged, unstaged or new files.
Documentation health:
Coverage debt: none. Every changed behavior has reference coverage. Diagram drift: none.
Tests
bun test test/gstack-checks.test.ts test/review-ledger-scope-bullets.test.ts test/ship-queue-stack-tests.test.ts test/spawn-sync.test.ts: 26 pass, 0 fail at 2c67625bun teston the review collector's scope-bullet, verdict-line, quiet-reply and invariant test files plus gstack-checks: 23 pass, 0 failAgent notes
Agent notes
Lane GSTA-653 for GST-3201. Two listed items were left out as larger than a small fix (decision trail rows 3 and 7): review-scope's
unbound=2on gstack-evals#378 (a late REVIEW_SINCE plus a trailer naming an outside Capy review finding, both gate-semantics choices), and the state-matrix gap that holds the Step 11 reader (a /ship review-flow prose change that needs a no-loss replay). lib/review-dispatch and lib/codex-rollout.ts are untouched. Fix round: Captain GStack Minder (GSTA-36) grant a-e9035eba61b8 for p1/outside-voice#1 and #2.REVIEW_LOOP: passes=1 blocking_found=2 deferred=0 noted=3 fixed=2 scope=frozen fix_checks=1 dispatches=4
Gate edits: none detected (6 listed, 2 read; patterns: RH-1,RH-3,RH-4,RH-12,RH-13,RH-14,RH-15,RH-16; unlisted idioms: none)
Refs p1/outside-voice#1
Refs p1/outside-voice#2
Approvals
Approved: yes (record r-94a1feaf730d). The full approval record stays private.
Plan: exempt: bug fix (R65, bug fixes skip plan review; repros in the tests)
Plan check: exempt bug fix