#8334 Persist viewer type in the map configuration#8990
Merged
offtherailz merged 10 commits intogeosolutions-it:masterfrom Mar 8, 2023
Merged
#8334 Persist viewer type in the map configuration#8990offtherailz merged 10 commits intogeosolutions-it:masterfrom
offtherailz merged 10 commits intogeosolutions-it:masterfrom
Conversation
2 tasks
offtherailz
requested changes
Mar 3, 2023
Member
offtherailz
left a comment
There was a problem hiding this comment.
Generally looks good. A few suggestion for clean up in the inline comments.
notes I asked serveral "use constants" in tests. It is a good practice, anyway I don't want to be to much boring
web/client/components/widgets/builder/wizard/map/enhancers/handleMapSelect.js
Outdated
Show resolved
Hide resolved
| static defaultProps = { | ||
| items: [], | ||
| mapType: "openlayers", | ||
| mapType: MapLibraries.OPENLAYERS, |
Member
There was a problem hiding this comment.
This can be removed, looks a copy and paste error
| title: <MenuItem header>Manager</MenuItem>, | ||
| controls: [], | ||
| mapType: "leaflet", | ||
| mapType: MapLibraries.LEAFLET, |
Member
There was a problem hiding this comment.
same of the other ToolContainer. it is used in it only. Moreover is set to leaflet and not mapped to the state, so I think it can be removed.
Contributor
Author
|
@offtherailz as discussed I'll move visualizationMode inside the map config |
offtherailz
approved these changes
Mar 8, 2023
This was referenced Mar 10, 2023
5 tasks
This was referenced Apr 5, 2024
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces the concept of visualization mode inside mapstore with following changes:
visualizationModeinformation inside the saved map configuration to persist the mode every time a map is opened/viewer/openlayers/1. This change has retrocompatible support by recognizing the visualization mode based on mapType provided in the url and replacing the url with the new format/viewer/1Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8334
What is the new behavior?
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information