#8334 Review mapType configuration and docs#9012
Merged
allyoucanmap merged 5 commits intogeosolutions-it:masterfrom Mar 13, 2023
Merged
#8334 Review mapType configuration and docs#9012allyoucanmap merged 5 commits intogeosolutions-it:masterfrom
allyoucanmap merged 5 commits intogeosolutions-it:masterfrom
Conversation
1 task
1 task
2 tasks
offtherailz
requested changes
Mar 13, 2023
Member
offtherailz
left a comment
There was a problem hiding this comment.
See only my comment about migration guidelines.
offtherailz
reviewed
Mar 13, 2023
offtherailz
reviewed
Mar 13, 2023
offtherailz
approved these changes
Mar 13, 2023
Contributor
Author
|
@ElenaGallo please test this fix on dev as part of the work done in the PR #8990, thanks |
2 tasks
1 task
This was referenced Apr 5, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The PR #8990 introduced the new configuration of mapType but it does not take into account the default visualization mode that for some custom downstream project could be needed (eg initialize the app only in 3D)
New proposed configuration for mapType is:
Please check if the PR fulfills these requirements
What kind of change does this PR introduce? (check one with "x", remove the others)
Issue
What is the current behavior?
#8334
What is the new behavior?
Review of new mapType configuration
Breaking change
Does this PR introduce a breaking change? (check one with "x", remove the other)
Other useful information