Conversation
more generic, applies to both linux-musl-x64 and linux-arm64
|
@bruno-garcia it's green 😉 |
| - "**/*DeviceTests*.csproj" | ||
| - "**/*Maui.Device.TestApp.csproj" | ||
|
|
||
| - outputPath: Sentry-CI-Build-Linux-arm64.slnf |
There was a problem hiding this comment.
Would it be nicer to have something like Sentry-CI-Build-Linux-only.slnf (or "no mobile" or whatever is a good name) to avoid duplicating the solution filter?
There was a problem hiding this comment.
Btw, happy to do a separate follow-up later if that works...
There was a problem hiding this comment.
This seems different then the other Linux though, no? Here we exclude Android too (not just tests)?
There was a problem hiding this comment.
This is a copy of Sentry-CI-Build-Linux-musl.slnf. I was wondering if those two could use the same "Linux-only" filter without any Android-related projects.
bruno-garcia
requested review from
Flash0ver,
aritchie and
jamescrosswell
as code owners
| key: sentry-native-Linux-${{ hashFiles('scripts/build-sentry-native.ps1') }}-${{ hashFiles('.git/modules/modules/sentry-native/HEAD') }} | ||
| fail-on-cache-miss: true | ||
|
|
||
| - name: Download sentry-native (Linux arm64) |
There was a problem hiding this comment.
I wonder if there's a way to combine all of these "Download sentry-native" steps into a single step with some variables.... maybe not in this PR but we should think about refactoring this before it gets out of hand.
| Describe 'MAUI' -ForEach @( | ||
| @{ framework = "net8.0" } | ||
| ) -Skip:$IsLinuxMusl { | ||
| ) -Skip:($env:NO_MOBILE -eq "true") { |
3 participants
Lets see what happens
#skip-changelog